Sign upLogin

modxcms/revolution

View on GitHub
Star
core/model/aws/services/cloudwatch.class.php

Summary

Maintainability
D
2 days
Test Coverage

Method put_metric_alarm has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function put_metric_alarm($alarm_name, $metric_name, $namespace, $statistic, $period, $evaluation_periods, $threshold, $comparison_operator, $opt = null)
    {
        if (!$opt) $opt = array();
        $opt['AlarmName'] = $alarm_name;
Severity: Minor
Found in core/model/aws/services/cloudwatch.class.php - About 1 hr to fix

    Method put_metric_alarm has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function put_metric_alarm($alarm_name, $metric_name, $namespace, $statistic, $period, $evaluation_periods, $threshold, $comparison_operator, $opt = null)
    Severity: Major
    Found in core/model/aws/services/cloudwatch.class.php - About 1 hr to fix

      Method get_metric_statistics has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function get_metric_statistics($namespace, $metric_name, $start_time, $end_time, $period, $statistics, $unit, $opt = null)
      Severity: Major
      Found in core/model/aws/services/cloudwatch.class.php - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function describe_alarms_for_metric($metric_name, $namespace, $opt = null)
    {
        if (!$opt) $opt = array();
        $opt['MetricName'] = $metric_name;
        $opt['Namespace'] = $namespace;
        Severity: Major
        Found in core/model/aws/services/cloudwatch.class.php and 1 other location - About 2 hrs to fix
        core/model/aws/services/elasticbeanstalk.class.php on lines 315..331

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 130.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 10 locations. Consider refactoring.
        Open

            public function describe_alarms($opt = null)
    {
        if (!$opt) $opt = array();

        // Optional parameter
        Severity: Major
        Found in core/model/aws/services/cloudwatch.class.php and 9 other locations - About 2 hrs to fix
        core/model/aws/services/as.class.php on lines 262..276
        core/model/aws/services/as.class.php on lines 310..324
        core/model/aws/services/as.class.php on lines 401..415
        core/model/aws/services/as.class.php on lines 467..481
        core/model/aws/services/as.class.php on lines 586..600
        core/model/aws/services/cloudformation.class.php on lines 159..173
        core/model/aws/services/elasticbeanstalk.class.php on lines 367..381
        core/model/aws/services/elasticbeanstalk.class.php on lines 920..934
        core/model/aws/services/elb.class.php on lines 340..354

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 125.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 13 locations. Consider refactoring.
        Open

            public function __construct($key = null, $secret_key = null)
    {
        $this->api_version = '2010-08-01';
        $this->hostname = self::DEFAULT_URL;
        Severity: Major
        Found in core/model/aws/services/cloudwatch.class.php and 12 other locations - About 1 hr to fix
        core/model/aws/services/as.class.php on lines 110..130
        core/model/aws/services/cloudformation.class.php on lines 120..140
        core/model/aws/services/elasticache.class.php on lines 78..98
        core/model/aws/services/elasticbeanstalk.class.php on lines 87..107
        core/model/aws/services/elb.class.php on lines 93..113
        core/model/aws/services/emr.class.php on lines 95..115
        core/model/aws/services/iam.class.php on lines 64..84
        core/model/aws/services/importexport.class.php on lines 54..74
        core/model/aws/services/rds.class.php on lines 99..119
        core/model/aws/services/sdb.class.php on lines 222..242
        core/model/aws/services/ses.class.php on lines 85..105
        core/model/aws/services/sts.class.php on lines 68..88

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 118.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            public function describe_alarm_history($opt = null)
    {
        if (!$opt) $opt = array();

        // Optional parameter
        Severity: Major
        Found in core/model/aws/services/cloudwatch.class.php and 3 other locations - About 1 hr to fix
        core/model/aws/services/elasticache.class.php on lines 335..352
        core/model/aws/services/elasticbeanstalk.class.php on lines 976..993
        core/model/aws/services/rds.class.php on lines 162..179

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 113.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            public function list_metrics($opt = null)
    {
        if (!$opt) $opt = array();

        // Optional parameter
        Severity: Major
        Found in core/model/aws/services/cloudwatch.class.php and 2 other locations - About 1 hr to fix
        core/model/aws/services/elasticbeanstalk.class.php on lines 152..166
        core/model/aws/services/emr.class.php on lines 465..479

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 100.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            public function enable_alarm_actions($alarm_names, $opt = null)
    {
        if (!$opt) $opt = array();

        // Required parameter
        Severity: Major
        Found in core/model/aws/services/cloudwatch.class.php and 3 other locations - About 55 mins to fix
        core/model/aws/services/cloudwatch.class.php on lines 411..421
        core/model/aws/services/cloudwatch.class.php on lines 562..572
        core/model/aws/services/emr.class.php on lines 221..231

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 99.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            public function disable_alarm_actions($alarm_names, $opt = null)
    {
        if (!$opt) $opt = array();

        // Required parameter
        Severity: Major
        Found in core/model/aws/services/cloudwatch.class.php and 3 other locations - About 55 mins to fix
        core/model/aws/services/cloudwatch.class.php on lines 540..550
        core/model/aws/services/cloudwatch.class.php on lines 562..572
        core/model/aws/services/emr.class.php on lines 221..231

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 99.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            public function delete_alarms($alarm_names, $opt = null)
    {
        if (!$opt) $opt = array();

        // Required parameter
        Severity: Major
        Found in core/model/aws/services/cloudwatch.class.php and 3 other locations - About 55 mins to fix
        core/model/aws/services/cloudwatch.class.php on lines 411..421
        core/model/aws/services/cloudwatch.class.php on lines 540..550
        core/model/aws/services/emr.class.php on lines 221..231

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 99.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 17 locations. Consider refactoring.
        Open

            public function set_alarm_state($alarm_name, $state_value, $state_reason, $opt = null)
    {
        if (!$opt) $opt = array();
        $opt['AlarmName'] = $alarm_name;
        $opt['StateValue'] = $state_value;
        Severity: Major
        Found in core/model/aws/services/cloudwatch.class.php and 16 other locations - About 30 mins to fix
        core/model/aws/services/ec2.class.php on lines 1077..1085
        core/model/aws/services/ec2.class.php on lines 1928..1936
        core/model/aws/services/ec2.class.php on lines 2028..2036
        core/model/aws/services/ec2.class.php on lines 3382..3390
        core/model/aws/services/elasticache.class.php on lines 206..214
        core/model/aws/services/elasticache.class.php on lines 517..525
        core/model/aws/services/elasticache.class.php on lines 567..575
        core/model/aws/services/elb.class.php on lines 441..449
        core/model/aws/services/elb.class.php on lines 502..510
        core/model/aws/services/iam.class.php on lines 251..259
        core/model/aws/services/iam.class.php on lines 542..550
        core/model/aws/services/iam.class.php on lines 760..768
        core/model/aws/services/importexport.class.php on lines 95..103
        core/model/aws/services/rds.class.php on lines 368..376
        core/model/aws/services/sns.class.php on lines 208..216
        core/model/aws/services/sns.class.php on lines 230..238

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 90.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status