Sign upLogin

modxcms/revolution

View on GitHub
Star
core/model/aws/services/elasticache.class.php

Summary

Maintainability
C
1 day
Test Coverage

Method create_cache_cluster has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function create_cache_cluster($cache_cluster_id, $num_cache_nodes, $cache_node_type, $engine, $cache_security_group_names, $opt = null)
Severity: Minor
Found in core/model/aws/services/elasticache.class.php - About 45 mins to fix

    Similar blocks of code found in 13 locations. Consider refactoring.
    Open

        public function __construct($key = null, $secret_key = null)
    {
        $this->api_version = '2011-07-15';
        $this->hostname = self::DEFAULT_URL;
    Severity: Major
    Found in core/model/aws/services/elasticache.class.php and 12 other locations - About 1 hr to fix
    core/model/aws/services/as.class.php on lines 110..130
    core/model/aws/services/cloudformation.class.php on lines 120..140
    core/model/aws/services/cloudwatch.class.php on lines 119..139
    core/model/aws/services/elasticbeanstalk.class.php on lines 87..107
    core/model/aws/services/elb.class.php on lines 93..113
    core/model/aws/services/emr.class.php on lines 95..115
    core/model/aws/services/iam.class.php on lines 64..84
    core/model/aws/services/importexport.class.php on lines 54..74
    core/model/aws/services/rds.class.php on lines 99..119
    core/model/aws/services/sdb.class.php on lines 222..242
    core/model/aws/services/ses.class.php on lines 85..105
    core/model/aws/services/sts.class.php on lines 68..88

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 118.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 13 locations. Consider refactoring.
    Open

        public function reset_cache_parameter_group($cache_parameter_group_name, $parameter_name_values, $opt = null)
    {
        if (!$opt) $opt = array();
        $opt['CacheParameterGroupName'] = $cache_parameter_group_name;
    Severity: Major
    Found in core/model/aws/services/elasticache.class.php and 12 other locations - About 1 hr to fix
    core/model/aws/services/elasticache.class.php on lines 141..152
    core/model/aws/services/elasticache.class.php on lines 542..553
    core/model/aws/services/elasticbeanstalk.class.php on lines 700..711
    core/model/aws/services/elb.class.php on lines 188..199
    core/model/aws/services/elb.class.php on lines 313..324
    core/model/aws/services/elb.class.php on lines 376..387
    core/model/aws/services/elb.class.php on lines 406..417
    core/model/aws/services/elb.class.php on lines 476..487
    core/model/aws/services/elb.class.php on lines 575..586
    core/model/aws/services/elb.class.php on lines 605..616
    core/model/aws/services/emr.class.php on lines 196..207
    core/model/aws/services/rds.class.php on lines 762..773

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 114.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 13 locations. Consider refactoring.
    Open

        public function modify_cache_parameter_group($cache_parameter_group_name, $parameter_name_values, $opt = null)
    {
        if (!$opt) $opt = array();
        $opt['CacheParameterGroupName'] = $cache_parameter_group_name;
    Severity: Major
    Found in core/model/aws/services/elasticache.class.php and 12 other locations - About 1 hr to fix
    core/model/aws/services/elasticache.class.php on lines 419..430
    core/model/aws/services/elasticache.class.php on lines 542..553
    core/model/aws/services/elasticbeanstalk.class.php on lines 700..711
    core/model/aws/services/elb.class.php on lines 188..199
    core/model/aws/services/elb.class.php on lines 313..324
    core/model/aws/services/elb.class.php on lines 376..387
    core/model/aws/services/elb.class.php on lines 406..417
    core/model/aws/services/elb.class.php on lines 476..487
    core/model/aws/services/elb.class.php on lines 575..586
    core/model/aws/services/elb.class.php on lines 605..616
    core/model/aws/services/emr.class.php on lines 196..207
    core/model/aws/services/rds.class.php on lines 762..773

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 114.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 13 locations. Consider refactoring.
    Open

        public function reboot_cache_cluster($cache_cluster_id, $cache_node_ids_to_reboot, $opt = null)
    {
        if (!$opt) $opt = array();
        $opt['CacheClusterId'] = $cache_cluster_id;
    Severity: Major
    Found in core/model/aws/services/elasticache.class.php and 12 other locations - About 1 hr to fix
    core/model/aws/services/elasticache.class.php on lines 141..152
    core/model/aws/services/elasticache.class.php on lines 419..430
    core/model/aws/services/elasticbeanstalk.class.php on lines 700..711
    core/model/aws/services/elb.class.php on lines 188..199
    core/model/aws/services/elb.class.php on lines 313..324
    core/model/aws/services/elb.class.php on lines 376..387
    core/model/aws/services/elb.class.php on lines 406..417
    core/model/aws/services/elb.class.php on lines 476..487
    core/model/aws/services/elb.class.php on lines 575..586
    core/model/aws/services/elb.class.php on lines 605..616
    core/model/aws/services/emr.class.php on lines 196..207
    core/model/aws/services/rds.class.php on lines 762..773

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 114.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        public function describe_events($opt = null)
    {
        if (!$opt) $opt = array();

        // Optional parameter
    Severity: Major
    Found in core/model/aws/services/elasticache.class.php and 3 other locations - About 1 hr to fix
    core/model/aws/services/cloudwatch.class.php on lines 511..528
    core/model/aws/services/elasticbeanstalk.class.php on lines 976..993
    core/model/aws/services/rds.class.php on lines 162..179

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 113.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 17 locations. Consider refactoring.
    Open

        public function create_cache_parameter_group($cache_parameter_group_name, $cache_parameter_group_family, $description, $opt = null)
    {
        if (!$opt) $opt = array();
        $opt['CacheParameterGroupName'] = $cache_parameter_group_name;
        $opt['CacheParameterGroupFamily'] = $cache_parameter_group_family;
    Severity: Major
    Found in core/model/aws/services/elasticache.class.php and 16 other locations - About 30 mins to fix
    core/model/aws/services/cloudwatch.class.php on lines 589..597
    core/model/aws/services/ec2.class.php on lines 1077..1085
    core/model/aws/services/ec2.class.php on lines 1928..1936
    core/model/aws/services/ec2.class.php on lines 2028..2036
    core/model/aws/services/ec2.class.php on lines 3382..3390
    core/model/aws/services/elasticache.class.php on lines 206..214
    core/model/aws/services/elasticache.class.php on lines 567..575
    core/model/aws/services/elb.class.php on lines 441..449
    core/model/aws/services/elb.class.php on lines 502..510
    core/model/aws/services/iam.class.php on lines 251..259
    core/model/aws/services/iam.class.php on lines 542..550
    core/model/aws/services/iam.class.php on lines 760..768
    core/model/aws/services/importexport.class.php on lines 95..103
    core/model/aws/services/rds.class.php on lines 368..376
    core/model/aws/services/sns.class.php on lines 208..216
    core/model/aws/services/sns.class.php on lines 230..238

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 90.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 17 locations. Consider refactoring.
    Open

        public function authorize_cache_security_group_ingress($cache_security_group_name, $ec2_security_group_name, $ec2_security_group_owner_id, $opt = null)
    {
        if (!$opt) $opt = array();
        $opt['CacheSecurityGroupName'] = $cache_security_group_name;
        $opt['EC2SecurityGroupName'] = $ec2_security_group_name;
    Severity: Major
    Found in core/model/aws/services/elasticache.class.php and 16 other locations - About 30 mins to fix
    core/model/aws/services/cloudwatch.class.php on lines 589..597
    core/model/aws/services/ec2.class.php on lines 1077..1085
    core/model/aws/services/ec2.class.php on lines 1928..1936
    core/model/aws/services/ec2.class.php on lines 2028..2036
    core/model/aws/services/ec2.class.php on lines 3382..3390
    core/model/aws/services/elasticache.class.php on lines 517..525
    core/model/aws/services/elasticache.class.php on lines 567..575
    core/model/aws/services/elb.class.php on lines 441..449
    core/model/aws/services/elb.class.php on lines 502..510
    core/model/aws/services/iam.class.php on lines 251..259
    core/model/aws/services/iam.class.php on lines 542..550
    core/model/aws/services/iam.class.php on lines 760..768
    core/model/aws/services/importexport.class.php on lines 95..103
    core/model/aws/services/rds.class.php on lines 368..376
    core/model/aws/services/sns.class.php on lines 208..216
    core/model/aws/services/sns.class.php on lines 230..238

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 90.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 17 locations. Consider refactoring.
    Open

        public function revoke_cache_security_group_ingress($cache_security_group_name, $ec2_security_group_name, $ec2_security_group_owner_id, $opt = null)
    {
        if (!$opt) $opt = array();
        $opt['CacheSecurityGroupName'] = $cache_security_group_name;
        $opt['EC2SecurityGroupName'] = $ec2_security_group_name;
    Severity: Major
    Found in core/model/aws/services/elasticache.class.php and 16 other locations - About 30 mins to fix
    core/model/aws/services/cloudwatch.class.php on lines 589..597
    core/model/aws/services/ec2.class.php on lines 1077..1085
    core/model/aws/services/ec2.class.php on lines 1928..1936
    core/model/aws/services/ec2.class.php on lines 2028..2036
    core/model/aws/services/ec2.class.php on lines 3382..3390
    core/model/aws/services/elasticache.class.php on lines 206..214
    core/model/aws/services/elasticache.class.php on lines 517..525
    core/model/aws/services/elb.class.php on lines 441..449
    core/model/aws/services/elb.class.php on lines 502..510
    core/model/aws/services/iam.class.php on lines 251..259
    core/model/aws/services/iam.class.php on lines 542..550
    core/model/aws/services/iam.class.php on lines 760..768
    core/model/aws/services/importexport.class.php on lines 95..103
    core/model/aws/services/rds.class.php on lines 368..376
    core/model/aws/services/sns.class.php on lines 208..216
    core/model/aws/services/sns.class.php on lines 230..238

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 90.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status