Sign upLogin

modxcms/revolution

View on GitHub
Star
core/model/aws/services/emr.class.php

Summary

Maintainability
C
1 day
Test Coverage

Method run_job_flow has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function run_job_flow($name, $instances, $opt = null)
    {
        if (!$opt) $opt = array();
        $opt['Name'] = $name;
Severity: Minor
Found in core/model/aws/services/emr.class.php - About 1 hr to fix

    Similar blocks of code found in 13 locations. Consider refactoring.
    Open

        public function __construct($key = null, $secret_key = null)
    {
        $this->api_version = '2009-03-31';
        $this->hostname = self::DEFAULT_URL;
    Severity: Major
    Found in core/model/aws/services/emr.class.php and 12 other locations - About 1 hr to fix
    core/model/aws/services/as.class.php on lines 110..130
    core/model/aws/services/cloudformation.class.php on lines 120..140
    core/model/aws/services/cloudwatch.class.php on lines 119..139
    core/model/aws/services/elasticache.class.php on lines 78..98
    core/model/aws/services/elasticbeanstalk.class.php on lines 87..107
    core/model/aws/services/elb.class.php on lines 93..113
    core/model/aws/services/iam.class.php on lines 64..84
    core/model/aws/services/importexport.class.php on lines 54..74
    core/model/aws/services/rds.class.php on lines 99..119
    core/model/aws/services/sdb.class.php on lines 222..242
    core/model/aws/services/ses.class.php on lines 85..105
    core/model/aws/services/sts.class.php on lines 68..88

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 118.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 13 locations. Consider refactoring.
    Open

        public function add_job_flow_steps($job_flow_id, $steps, $opt = null)
    {
        if (!$opt) $opt = array();
        $opt['JobFlowId'] = $job_flow_id;
    Severity: Major
    Found in core/model/aws/services/emr.class.php and 12 other locations - About 1 hr to fix
    core/model/aws/services/elasticache.class.php on lines 141..152
    core/model/aws/services/elasticache.class.php on lines 419..430
    core/model/aws/services/elasticache.class.php on lines 542..553
    core/model/aws/services/elasticbeanstalk.class.php on lines 700..711
    core/model/aws/services/elb.class.php on lines 188..199
    core/model/aws/services/elb.class.php on lines 313..324
    core/model/aws/services/elb.class.php on lines 376..387
    core/model/aws/services/elb.class.php on lines 406..417
    core/model/aws/services/elb.class.php on lines 476..487
    core/model/aws/services/elb.class.php on lines 575..586
    core/model/aws/services/elb.class.php on lines 605..616
    core/model/aws/services/rds.class.php on lines 762..773

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 114.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public function add_instance_groups($instance_groups, $job_flow_id, $opt = null)
    {
        if (!$opt) $opt = array();

        // Required parameter
    Severity: Major
    Found in core/model/aws/services/emr.class.php and 1 other location - About 1 hr to fix
    core/model/aws/services/emr.class.php on lines 321..332

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 114.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public function set_termination_protection($job_flow_ids, $termination_protected, $opt = null)
    {
        if (!$opt) $opt = array();

        // Required parameter
    Severity: Major
    Found in core/model/aws/services/emr.class.php and 1 other location - About 1 hr to fix
    core/model/aws/services/emr.class.php on lines 141..152

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 114.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        public function modify_instance_groups($opt = null)
    {
        if (!$opt) $opt = array();

        // Optional parameter
    Severity: Major
    Found in core/model/aws/services/emr.class.php and 2 other locations - About 1 hr to fix
    core/model/aws/services/cloudwatch.class.php on lines 314..328
    core/model/aws/services/elasticbeanstalk.class.php on lines 152..166

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 100.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        public function terminate_job_flows($job_flow_ids, $opt = null)
    {
        if (!$opt) $opt = array();

        // Required parameter
    Severity: Major
    Found in core/model/aws/services/emr.class.php and 3 other locations - About 55 mins to fix
    core/model/aws/services/cloudwatch.class.php on lines 411..421
    core/model/aws/services/cloudwatch.class.php on lines 540..550
    core/model/aws/services/cloudwatch.class.php on lines 562..572

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 99.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status