Sign upLogin

modxcms/revolution

View on GitHub
Star
core/model/aws/services/iam.class.php

Summary

Maintainability
D
2 days
Test Coverage

AmazonIAM has 47 functions (exceeds 20 allowed). Consider refactoring.
Open

class AmazonIAM extends CFRuntime
{

    /*%******************************************************************************************%*/
    // CLASS CONSTANTS
Severity: Minor
Found in core/model/aws/services/iam.class.php - About 6 hrs to fix

    File iam.class.php has 309 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/*
 * Copyright 2010-2011 Amazon.com, Inc. or its affiliates. All Rights Reserved.
 *
 * Licensed under the Apache License, Version 2.0 (the "License").
    Severity: Minor
    Found in core/model/aws/services/iam.class.php - About 3 hrs to fix

      Method resync_mfa_device has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function resync_mfa_device($user_name, $serial_number, $authentication_code1, $authentication_code2, $opt = null)
      Severity: Minor
      Found in core/model/aws/services/iam.class.php - About 35 mins to fix

        Method enable_mfa_device has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function enable_mfa_device($user_name, $serial_number, $authentication_code1, $authentication_code2, $opt = null)
        Severity: Minor
        Found in core/model/aws/services/iam.class.php - About 35 mins to fix

          Similar blocks of code found in 13 locations. Consider refactoring.
          Open

              public function __construct($key = null, $secret_key = null)
    {
        $this->api_version = '2010-05-08';
        $this->hostname = self::DEFAULT_URL;
          Severity: Major
          Found in core/model/aws/services/iam.class.php and 12 other locations - About 1 hr to fix
          core/model/aws/services/as.class.php on lines 110..130
          core/model/aws/services/cloudformation.class.php on lines 120..140
          core/model/aws/services/cloudwatch.class.php on lines 119..139
          core/model/aws/services/elasticache.class.php on lines 78..98
          core/model/aws/services/elasticbeanstalk.class.php on lines 87..107
          core/model/aws/services/elb.class.php on lines 93..113
          core/model/aws/services/emr.class.php on lines 95..115
          core/model/aws/services/importexport.class.php on lines 54..74
          core/model/aws/services/rds.class.php on lines 99..119
          core/model/aws/services/sdb.class.php on lines 222..242
          core/model/aws/services/ses.class.php on lines 85..105
          core/model/aws/services/sts.class.php on lines 68..88

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 118.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              public function resync_mfa_device($user_name, $serial_number, $authentication_code1, $authentication_code2, $opt = null)
    {
        if (!$opt) $opt = array();
        $opt['UserName'] = $user_name;
        $opt['SerialNumber'] = $serial_number;
          Severity: Major
          Found in core/model/aws/services/iam.class.php and 3 other locations - About 1 hr to fix
          core/model/aws/services/as.class.php on lines 638..647
          core/model/aws/services/iam.class.php on lines 612..621
          core/model/aws/services/importexport.class.php on lines 178..187

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 105.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              public function enable_mfa_device($user_name, $serial_number, $authentication_code1, $authentication_code2, $opt = null)
    {
        if (!$opt) $opt = array();
        $opt['UserName'] = $user_name;
        $opt['SerialNumber'] = $serial_number;
          Severity: Major
          Found in core/model/aws/services/iam.class.php and 3 other locations - About 1 hr to fix
          core/model/aws/services/as.class.php on lines 638..647
          core/model/aws/services/iam.class.php on lines 999..1008
          core/model/aws/services/importexport.class.php on lines 178..187

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 105.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 17 locations. Consider refactoring.
          Open

              public function put_group_policy($group_name, $policy_name, $policy_document, $opt = null)
    {
        if (!$opt) $opt = array();
        $opt['GroupName'] = $group_name;
        $opt['PolicyName'] = $policy_name;
          Severity: Major
          Found in core/model/aws/services/iam.class.php and 16 other locations - About 30 mins to fix
          core/model/aws/services/cloudwatch.class.php on lines 589..597
          core/model/aws/services/ec2.class.php on lines 1077..1085
          core/model/aws/services/ec2.class.php on lines 1928..1936
          core/model/aws/services/ec2.class.php on lines 2028..2036
          core/model/aws/services/ec2.class.php on lines 3382..3390
          core/model/aws/services/elasticache.class.php on lines 206..214
          core/model/aws/services/elasticache.class.php on lines 517..525
          core/model/aws/services/elasticache.class.php on lines 567..575
          core/model/aws/services/elb.class.php on lines 441..449
          core/model/aws/services/elb.class.php on lines 502..510
          core/model/aws/services/iam.class.php on lines 251..259
          core/model/aws/services/iam.class.php on lines 760..768
          core/model/aws/services/importexport.class.php on lines 95..103
          core/model/aws/services/rds.class.php on lines 368..376
          core/model/aws/services/sns.class.php on lines 208..216
          core/model/aws/services/sns.class.php on lines 230..238

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 90.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 17 locations. Consider refactoring.
          Open

              public function put_user_policy($user_name, $policy_name, $policy_document, $opt = null)
    {
        if (!$opt) $opt = array();
        $opt['UserName'] = $user_name;
        $opt['PolicyName'] = $policy_name;
          Severity: Major
          Found in core/model/aws/services/iam.class.php and 16 other locations - About 30 mins to fix
          core/model/aws/services/cloudwatch.class.php on lines 589..597
          core/model/aws/services/ec2.class.php on lines 1077..1085
          core/model/aws/services/ec2.class.php on lines 1928..1936
          core/model/aws/services/ec2.class.php on lines 2028..2036
          core/model/aws/services/ec2.class.php on lines 3382..3390
          core/model/aws/services/elasticache.class.php on lines 206..214
          core/model/aws/services/elasticache.class.php on lines 517..525
          core/model/aws/services/elasticache.class.php on lines 567..575
          core/model/aws/services/elb.class.php on lines 441..449
          core/model/aws/services/elb.class.php on lines 502..510
          core/model/aws/services/iam.class.php on lines 542..550
          core/model/aws/services/iam.class.php on lines 760..768
          core/model/aws/services/importexport.class.php on lines 95..103
          core/model/aws/services/rds.class.php on lines 368..376
          core/model/aws/services/sns.class.php on lines 208..216
          core/model/aws/services/sns.class.php on lines 230..238

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 90.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 17 locations. Consider refactoring.
          Open

              public function upload_server_certificate($server_certificate_name, $certificate_body, $private_key, $opt = null)
    {
        if (!$opt) $opt = array();
        $opt['ServerCertificateName'] = $server_certificate_name;
        $opt['CertificateBody'] = $certificate_body;
          Severity: Major
          Found in core/model/aws/services/iam.class.php and 16 other locations - About 30 mins to fix
          core/model/aws/services/cloudwatch.class.php on lines 589..597
          core/model/aws/services/ec2.class.php on lines 1077..1085
          core/model/aws/services/ec2.class.php on lines 1928..1936
          core/model/aws/services/ec2.class.php on lines 2028..2036
          core/model/aws/services/ec2.class.php on lines 3382..3390
          core/model/aws/services/elasticache.class.php on lines 206..214
          core/model/aws/services/elasticache.class.php on lines 517..525
          core/model/aws/services/elasticache.class.php on lines 567..575
          core/model/aws/services/elb.class.php on lines 441..449
          core/model/aws/services/elb.class.php on lines 502..510
          core/model/aws/services/iam.class.php on lines 251..259
          core/model/aws/services/iam.class.php on lines 542..550
          core/model/aws/services/importexport.class.php on lines 95..103
          core/model/aws/services/rds.class.php on lines 368..376
          core/model/aws/services/sns.class.php on lines 208..216
          core/model/aws/services/sns.class.php on lines 230..238

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 90.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status