modxcms/revolution

View on GitHub
core/model/modx/mail/phpmailer/src/SMTP.php

Summary

Maintainability
F
1 wk
Test Coverage

File SMTP.php has 718 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * PHPMailer RFC821 SMTP email transport class.
 * PHP Version 5.5.
Severity: Major
Found in core/model/modx/mail/phpmailer/src/SMTP.php - About 1 day to fix

    Function authenticate has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
    Open

        public function authenticate(
            $username,
            $password,
            $authtype = null,
            $OAuth = null
    Severity: Minor
    Found in core/model/modx/mail/phpmailer/src/SMTP.php - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    SMTP has 39 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class SMTP
    {
        /**
         * The PHPMailer SMTP version number.
         *
    Severity: Minor
    Found in core/model/modx/mail/phpmailer/src/SMTP.php - About 5 hrs to fix

      Function get_lines has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function get_lines()
          {
              //If the connection is bad, give up straight away
              if (!is_resource($this->smtp_conn)) {
                  return '';
      Severity: Minor
      Found in core/model/modx/mail/phpmailer/src/SMTP.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method authenticate has 85 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function authenticate(
              $username,
              $password,
              $authtype = null,
              $OAuth = null
      Severity: Major
      Found in core/model/modx/mail/phpmailer/src/SMTP.php - About 3 hrs to fix

        Function data has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
        Open

            public function data($msg_data)
            {
                //This will use the standard timelimit
                if (!$this->sendCommand('DATA', 'DATA', 354)) {
                    return false;
        Severity: Minor
        Found in core/model/modx/mail/phpmailer/src/SMTP.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method get_lines has 62 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function get_lines()
            {
                //If the connection is bad, give up straight away
                if (!is_resource($this->smtp_conn)) {
                    return '';
        Severity: Major
        Found in core/model/modx/mail/phpmailer/src/SMTP.php - About 2 hrs to fix

          Function parseHelloFields has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function parseHelloFields($type)
              {
                  $this->server_caps = [];
                  $lines = explode("\n", $this->helo_rply);
          
          
          Severity: Minor
          Found in core/model/modx/mail/phpmailer/src/SMTP.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method getSMTPConnection has 55 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function getSMTPConnection($host, $port = null, $timeout = 30, $options = [])
              {
                  static $streamok;
                  //This is enabled by default since 5.0.0 but some providers disable it
                  //Check this once and cache the result
          Severity: Major
          Found in core/model/modx/mail/phpmailer/src/SMTP.php - About 2 hrs to fix

            Method data has 42 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function data($msg_data)
                {
                    //This will use the standard timelimit
                    if (!$this->sendCommand('DATA', 'DATA', 354)) {
                        return false;
            Severity: Minor
            Found in core/model/modx/mail/phpmailer/src/SMTP.php - About 1 hr to fix

              Method sendCommand has 41 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  protected function sendCommand($command, $commandstring, $expect)
                  {
                      if (!$this->connected()) {
                          $this->setError("Called $command without being connected");
              
              
              Severity: Minor
              Found in core/model/modx/mail/phpmailer/src/SMTP.php - About 1 hr to fix

                Method edebug has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    protected function edebug($str, $level = 0)
                    {
                        if ($level > $this->do_debug) {
                            return;
                        }
                Severity: Minor
                Found in core/model/modx/mail/phpmailer/src/SMTP.php - About 1 hr to fix

                  Function recipient has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function recipient($address, $dsn = '')
                      {
                          if (empty($dsn)) {
                              $rcpt = 'RCPT TO:<' . $address . '>';
                          } else {
                  Severity: Minor
                  Found in core/model/modx/mail/phpmailer/src/SMTP.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method parseHelloFields has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      protected function parseHelloFields($type)
                      {
                          $this->server_caps = [];
                          $lines = explode("\n", $this->helo_rply);
                  
                  
                  Severity: Minor
                  Found in core/model/modx/mail/phpmailer/src/SMTP.php - About 1 hr to fix

                    Method connect has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function connect($host, $port = null, $timeout = 30, $options = [])
                        {
                            //Clear errors to avoid confusion
                            $this->setError('');
                            //Make sure we are __not__ connected
                    Severity: Minor
                    Found in core/model/modx/mail/phpmailer/src/SMTP.php - About 1 hr to fix

                      Function recordLastTransactionID has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                      Open

                          protected function recordLastTransactionID()
                          {
                              $reply = $this->getLastReply();
                      
                              if (empty($reply)) {
                      Severity: Minor
                      Found in core/model/modx/mail/phpmailer/src/SMTP.php - About 45 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function getSMTPConnection has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                      Open

                          protected function getSMTPConnection($host, $port = null, $timeout = 30, $options = [])
                          {
                              static $streamok;
                              //This is enabled by default since 5.0.0 but some providers disable it
                              //Check this once and cache the result
                      Severity: Minor
                      Found in core/model/modx/mail/phpmailer/src/SMTP.php - About 45 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function edebug has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                      Open

                          protected function edebug($str, $level = 0)
                          {
                              if ($level > $this->do_debug) {
                                  return;
                              }
                      Severity: Minor
                      Found in core/model/modx/mail/phpmailer/src/SMTP.php - About 35 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function getServerExt has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function getServerExt($name)
                          {
                              if (!$this->server_caps) {
                                  $this->setError('No HELO/EHLO was sent');
                      
                      
                      Severity: Minor
                      Found in core/model/modx/mail/phpmailer/src/SMTP.php - About 35 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Avoid too many return statements within this method.
                      Open

                                          return false;
                      Severity: Major
                      Found in core/model/modx/mail/phpmailer/src/SMTP.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                            return false;
                        Severity: Major
                        Found in core/model/modx/mail/phpmailer/src/SMTP.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                              return false;
                          Severity: Major
                          Found in core/model/modx/mail/phpmailer/src/SMTP.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                                return false;
                            Severity: Major
                            Found in core/model/modx/mail/phpmailer/src/SMTP.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                              return false;
                              Severity: Major
                              Found in core/model/modx/mail/phpmailer/src/SMTP.php - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                                    return false;
                                Severity: Major
                                Found in core/model/modx/mail/phpmailer/src/SMTP.php - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                                  return $this->sendCommand('Username', base64_encode($response), 235);
                                  Severity: Major
                                  Found in core/model/modx/mail/phpmailer/src/SMTP.php - About 30 mins to fix

                                    Avoid too many return statements within this method.
                                    Open

                                                        return false;
                                    Severity: Major
                                    Found in core/model/modx/mail/phpmailer/src/SMTP.php - About 30 mins to fix

                                      Avoid too many return statements within this method.
                                      Open

                                              return $this->server_caps[$name];
                                      Severity: Major
                                      Found in core/model/modx/mail/phpmailer/src/SMTP.php - About 30 mins to fix

                                        Avoid too many return statements within this method.
                                        Open

                                                            return false;
                                        Severity: Major
                                        Found in core/model/modx/mail/phpmailer/src/SMTP.php - About 30 mins to fix

                                          Avoid too many return statements within this method.
                                          Open

                                                              return false;
                                          Severity: Major
                                          Found in core/model/modx/mail/phpmailer/src/SMTP.php - About 30 mins to fix

                                            Avoid too many return statements within this method.
                                            Open

                                                    return true;
                                            Severity: Major
                                            Found in core/model/modx/mail/phpmailer/src/SMTP.php - About 30 mins to fix

                                              Function sendCommand has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                              Open

                                                  protected function sendCommand($command, $commandstring, $expect)
                                                  {
                                                      if (!$this->connected()) {
                                                          $this->setError("Called $command without being connected");
                                              
                                              
                                              Severity: Minor
                                              Found in core/model/modx/mail/phpmailer/src/SMTP.php - About 25 mins to fix

                                              Cognitive Complexity

                                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                              A method's cognitive complexity is based on a few simple rules:

                                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                              • Code is considered more complex for each "break in the linear flow of the code"
                                              • Code is considered more complex when "flow breaking structures are nested"

                                              Further reading

                                              There are no issues that match your filters.

                                              Category
                                              Status