Sign upLogin

modxcms/revolution

View on GitHub
Star
core/model/modx/modcontext.class.php

Summary

Maintainability
F
3 days
Test Coverage

Function makeUrl has a Cognitive Complexity of 87 (exceeds 5 allowed). Consider refactoring.
Open

    public function makeUrl($id, $args = '', $scheme = -1, array $options = array()) {
        $url = '';
        $found = false;
        if ($id= intval($id)) {
            if ($this->config === null) {
Severity: Minor
Found in core/model/modx/modcontext.class.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method makeUrl has 103 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function makeUrl($id, $args = '', $scheme = -1, array $options = array()) {
        $url = '';
        $found = false;
        if ($id= intval($id)) {
            if ($this->config === null) {
Severity: Major
Found in core/model/modx/modcontext.class.php - About 4 hrs to fix

    Function prepare has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

        public function prepare($regenerate= false, array $options = array()) {
        $prepared= false;
        if ($this->config === null || $regenerate) {
            if ($this->xpdo->getCacheManager()) {
                $context = array();
    Severity: Minor
    Found in core/model/modx/modcontext.class.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File modcontext.class.php has 261 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/*
 * This file is part of MODX Revolution.
 *
 * Copyright (c) MODX, LLC. All Rights Reserved.
    Severity: Minor
    Found in core/model/modx/modcontext.class.php - About 2 hrs to fix

      Method findPolicy has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function findPolicy($context = '') {
        $policy = array();
        $enabled = true;
        $context = !empty($context) ? $context : $this->xpdo->context->get('key');
        if (!is_object($this->xpdo->context) || $context === $this->xpdo->context->get('key')) {
      Severity: Minor
      Found in core/model/modx/modcontext.class.php - About 1 hr to fix

        Function findPolicy has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            public function findPolicy($context = '') {
        $policy = array();
        $enabled = true;
        $context = !empty($context) ? $context : $this->xpdo->context->get('key');
        if (!is_object($this->xpdo->context) || $context === $this->xpdo->context->get('key')) {
        Severity: Minor
        Found in core/model/modx/modcontext.class.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method prepare has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function prepare($regenerate= false, array $options = array()) {
        $prepared= false;
        if ($this->config === null || $regenerate) {
            if ($this->xpdo->getCacheManager()) {
                $context = array();
        Severity: Minor
        Found in core/model/modx/modcontext.class.php - About 1 hr to fix

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              public function remove(array $ancestors = array()) {
        if ($this->xpdo instanceof modX) {
            $this->xpdo->invokeEvent('OnContextBeforeRemove',array(
                'context' => &$this,
                'ancestors' => $ancestors,
          Severity: Major
          Found in core/model/modx/modcontext.class.php and 2 other locations - About 1 hr to fix
          core/model/modx/modpluginevent.class.php on lines 54..71
          core/model/modx/modpropertyset.class.php on lines 222..239

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 106.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          foreach ($acls as $acl) {
                    $policy['modAccessContext'][$acl->get('target')][] = array(
                        'principal' => $acl->get('principal'),
                        'authority' => $acl->get('authority'),
                        'policy' => $acl->get('data') ? $this->xpdo->fromJSON($acl->get('data'), true) : array(),
          Severity: Minor
          Found in core/model/modx/modcontext.class.php and 1 other location - About 30 mins to fix
          core/model/modx/modcategory.class.php on lines 165..171

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 90.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status