Sign upLogin

modxcms/revolution

View on GitHub
Star
core/model/modx/sqlsrv/modmenu.map.inc.php

Summary

Maintainability
C
1 day
Test Coverage

Similar blocks of code found in 18 locations. Consider refactoring.
Open

  'indexes' => 
  array (
    'PRIMARY' => 
    array (
      'alias' => 'PRIMARY',
Severity: Major
Found in core/model/modx/sqlsrv/modmenu.map.inc.php and 17 other locations - About 1 day to fix
core/model/modx/mysql/modaccesspolicy.map.inc.php on lines 84..150
core/model/modx/mysql/modchunk.map.inc.php on lines 116..182
core/model/modx/mysql/moddashboardwidget.map.inc.php on lines 81..147
core/model/modx/mysql/modformcustomizationset.map.inc.php on lines 96..162
core/model/modx/mysql/modlexiconentry.map.inc.php on lines 84..150
core/model/modx/mysql/modmenu.map.inc.php on lines 113..179
core/model/modx/mysql/modtemplate.map.inc.php on lines 123..189
core/model/modx/mysql/moduser.map.inc.php on lines 140..206
core/model/modx/mysql/modusergroup.map.inc.php on lines 70..136
core/model/modx/sqlsrv/modaccesspolicy.map.inc.php on lines 78..144
core/model/modx/sqlsrv/modchunk.map.inc.php on lines 108..174
core/model/modx/sqlsrv/moddashboardwidget.map.inc.php on lines 78..144
core/model/modx/sqlsrv/modformcustomizationset.map.inc.php on lines 91..157
core/model/modx/sqlsrv/modlexiconentry.map.inc.php on lines 79..145
core/model/modx/sqlsrv/modtemplate.map.inc.php on lines 114..180
core/model/modx/sqlsrv/moduser.map.inc.php on lines 131..197
core/model/modx/sqlsrv/modusergroup.map.inc.php on lines 60..126

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 254.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 16 locations. Consider refactoring.
Open

  'aggregates' => 
  array (
    'Action' => 
    array (
      'class' => 'modAction',
Severity: Major
Found in core/model/modx/sqlsrv/modmenu.map.inc.php and 15 other locations - About 55 mins to fix
core/model/modx/mysql/modformcustomizationset.map.inc.php on lines 174..200
core/model/modx/mysql/modmenu.map.inc.php on lines 191..217
core/model/modx/mysql/modpluginevent.map.inc.php on lines 103..129
core/model/modx/mysql/modresourcegroup.map.inc.php on lines 70..96
core/model/modx/mysql/modusergroup.map.inc.php on lines 156..182
core/model/modx/mysql/modusergroupmember.map.inc.php on lines 98..124
core/model/modx/sources/mysql/modmediasourceelement.map.inc.php on lines 100..126
core/model/modx/sources/sqlsrv/modmediasourceelement.map.inc.php on lines 92..118
core/model/modx/sqlsrv/modcontext.map.inc.php on lines 102..128
core/model/modx/sqlsrv/modformcustomizationset.map.inc.php on lines 169..195
core/model/modx/sqlsrv/modpluginevent.map.inc.php on lines 95..121
core/model/modx/sqlsrv/modresourcegroup.map.inc.php on lines 62..88
core/model/modx/sqlsrv/moduser.map.inc.php on lines 198..224
core/model/modx/sqlsrv/modusergroup.map.inc.php on lines 146..172
core/model/modx/sqlsrv/modusergroupmember.map.inc.php on lines 86..112

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 99.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status