Sign upLogin

modxcms/revolution

View on GitHub
Star
core/model/modx/sqlsrv/modusergroupmember.map.inc.php

Summary

Maintainability
A
3 hrs
Test Coverage

Similar blocks of code found in 23 locations. Consider refactoring.
Open

  'indexes' => 
  array (
    'role' => 
    array (
      'alias' => 'role',
Severity: Major
Found in core/model/modx/sqlsrv/modusergroupmember.map.inc.php and 22 other locations - About 2 hrs to fix
core/model/modx/mysql/modaccesspermission.map.inc.php on lines 60..94
core/model/modx/mysql/modaction.map.inc.php on lines 73..107
core/model/modx/mysql/moddashboard.map.inc.php on lines 48..82
core/model/modx/mysql/modextensionpackage.map.inc.php on lines 89..123
core/model/modx/mysql/modpropertyset.map.inc.php on lines 57..91
core/model/modx/mysql/modresourcegroupresource.map.inc.php on lines 41..75
core/model/modx/mysql/modscript.map.inc.php on lines 59..93
core/model/modx/mysql/modsession.map.inc.php on lines 46..80
core/model/modx/mysql/modusergroupmember.map.inc.php on lines 63..97
core/model/modx/mysql/modusergrouprole.map.inc.php on lines 47..81
core/model/modx/registry/db/mysql/moddbregistertopic.map.inc.php on lines 60..94
core/model/modx/registry/db/sqlsrv/moddbregistertopic.map.inc.php on lines 58..92
core/model/modx/sqlsrv/modaccesspermission.map.inc.php on lines 53..87
core/model/modx/sqlsrv/modaction.map.inc.php on lines 71..105
core/model/modx/sqlsrv/moddashboard.map.inc.php on lines 42..76
core/model/modx/sqlsrv/modplugin.map.inc.php on lines 93..127
core/model/modx/sqlsrv/modpropertyset.map.inc.php on lines 53..87
core/model/modx/sqlsrv/modresourcegroupresource.map.inc.php on lines 35..69
core/model/modx/sqlsrv/modscript.map.inc.php on lines 53..87
core/model/modx/sqlsrv/modsession.map.inc.php on lines 41..75
core/model/modx/sqlsrv/modsnippet.map.inc.php on lines 82..116
core/model/modx/sqlsrv/modusergrouprole.map.inc.php on lines 42..76

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 130.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 16 locations. Consider refactoring.
Open

  'aggregates' => 
  array (
    'UserGroupRole' => 
    array (
      'class' => 'modUserGroupRole',
Severity: Major
Found in core/model/modx/sqlsrv/modusergroupmember.map.inc.php and 15 other locations - About 55 mins to fix
core/model/modx/mysql/modformcustomizationset.map.inc.php on lines 174..200
core/model/modx/mysql/modmenu.map.inc.php on lines 191..217
core/model/modx/mysql/modpluginevent.map.inc.php on lines 103..129
core/model/modx/mysql/modresourcegroup.map.inc.php on lines 70..96
core/model/modx/mysql/modusergroup.map.inc.php on lines 156..182
core/model/modx/mysql/modusergroupmember.map.inc.php on lines 98..124
core/model/modx/sources/mysql/modmediasourceelement.map.inc.php on lines 100..126
core/model/modx/sources/sqlsrv/modmediasourceelement.map.inc.php on lines 92..118
core/model/modx/sqlsrv/modcontext.map.inc.php on lines 102..128
core/model/modx/sqlsrv/modformcustomizationset.map.inc.php on lines 169..195
core/model/modx/sqlsrv/modmenu.map.inc.php on lines 188..214
core/model/modx/sqlsrv/modpluginevent.map.inc.php on lines 95..121
core/model/modx/sqlsrv/modresourcegroup.map.inc.php on lines 62..88
core/model/modx/sqlsrv/moduser.map.inc.php on lines 198..224
core/model/modx/sqlsrv/modusergroup.map.inc.php on lines 146..172

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 99.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status