Sign upLogin

modxcms/revolution

View on GitHub
Star
core/model/modx/transport/sqlsrv/modtransportpackage.class.php

Summary

Maintainability
D
2 days
Test Coverage

Method listPackages has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function listPackages(modX &$modx, $workspace, $limit = 0, $offset = 0,$search = '') {
        $result = array('collection' => array(), 'total' => 0);
        $c = $modx->newQuery('transport.modTransportPackage');
        $c->leftJoin('transport.modTransportProvider','Provider', array("modTransportPackage.provider = Provider.id"));
        $c->where(array(
Severity: Minor
Found in core/model/modx/transport/sqlsrv/modtransportpackage.class.php - About 1 hr to fix

    Method listPackages has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public static function listPackages(modX &$modx, $workspace, $limit = 0, $offset = 0,$search = '') {
    Severity: Minor
    Found in core/model/modx/transport/sqlsrv/modtransportpackage.class.php - About 35 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      class modTransportPackage_sqlsrv extends modTransportPackage {
    public static function listPackages(modX &$modx, $workspace, $limit = 0, $offset = 0,$search = '') {
        $result = array('collection' => array(), 'total' => 0);
        $c = $modx->newQuery('transport.modTransportPackage');
        $c->leftJoin('transport.modTransportProvider','Provider', array("modTransportPackage.provider = Provider.id"));
      Severity: Major
      Found in core/model/modx/transport/sqlsrv/modtransportpackage.class.php and 1 other location - About 2 days to fix
      core/model/modx/transport/mysql/modtransportpackage.class.php on lines 16..73

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 513.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status