Sign upLogin

modxcms/revolution

View on GitHub
Star
core/model/phpthumb/modphpthumb.class.php

Summary

Maintainability
D
3 days
Test Coverage

Function ResolveFilenameToAbsolute has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
Open

    function ResolveFilenameToAbsolute($filename) {
        if (empty($filename)) {
            return false;
        }
Severity: Minor
Found in core/model/phpthumb/modphpthumb.class.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function RedirectToCachedFile has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

    public function RedirectToCachedFile() {

        $nice_cachefile = str_replace(DIRECTORY_SEPARATOR, '/', $this->cache_filename);
        $nice_docroot   = str_replace(DIRECTORY_SEPARATOR, '/', rtrim($this->config_document_root, '/\\'));
Severity: Minor
Found in core/model/phpthumb/modphpthumb.class.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method ResolveFilenameToAbsolute has 72 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function ResolveFilenameToAbsolute($filename) {
        if (empty($filename)) {
            return false;
        }
Severity: Major
Found in core/model/phpthumb/modphpthumb.class.php - About 2 hrs to fix

    File modphpthumb.class.php has 257 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/*
 * This file is part of MODX Revolution.
 *
 * Copyright (c) MODX, LLC. All Rights Reserved.
    Severity: Minor
    Found in core/model/phpthumb/modphpthumb.class.php - About 2 hrs to fix

      Method RedirectToCachedFile has 53 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function RedirectToCachedFile() {

        $nice_cachefile = str_replace(DIRECTORY_SEPARATOR, '/', $this->cache_filename);
        $nice_docroot   = str_replace(DIRECTORY_SEPARATOR, '/', rtrim($this->config_document_root, '/\\'));
      Severity: Major
      Found in core/model/phpthumb/modphpthumb.class.php - About 2 hrs to fix

        Method initialize has 51 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function initialize()
    {
        $cachePath = $this->modx->getOption('core_path',null,MODX_CORE_PATH).'cache/phpthumb/';
        if (!is_dir($cachePath)) {
            $this->modx->cacheManager->writeTree($cachePath);
        Severity: Major
        Found in core/model/phpthumb/modphpthumb.class.php - About 2 hrs to fix

          Function initialize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public function initialize()
    {
        $cachePath = $this->modx->getOption('core_path',null,MODX_CORE_PATH).'cache/phpthumb/';
        if (!is_dir($cachePath)) {
            $this->modx->cacheManager->writeTree($cachePath);
          Severity: Minor
          Found in core/model/phpthumb/modphpthumb.class.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                  return $AbsoluteFilename;
          Severity: Major
          Found in core/model/phpthumb/modphpthumb.class.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return false;
            Severity: Major
            Found in core/model/phpthumb/modphpthumb.class.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return false;
              Severity: Major
              Found in core/model/phpthumb/modphpthumb.class.php - About 30 mins to fix

                Function cache has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function cache() {
        phpthumb_functions::EnsureDirectoryExists(dirname($this->cache_filename));
        if ((file_exists($this->cache_filename) && is_writable($this->cache_filename)) || is_writable(dirname($this->cache_filename))) {
            $this->CleanUpCacheDirectory();
            if ($this->RenderToFile($this->cache_filename) && is_readable($this->cache_filename)) {
                Severity: Minor
                Found in core/model/phpthumb/modphpthumb.class.php - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                            if (is_readable($filename) && !is_readable($this->config_document_root.$filename)) {

                // absolute filename (*nix)
                $AbsoluteFilename = $filename;
                Severity: Major
                Found in core/model/phpthumb/modphpthumb.class.php and 1 other location - About 2 hrs to fix
                core/model/phpthumb/phpthumb.class.php on lines 1383..1415

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 140.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status