Sign upLogin

modxcms/revolution

View on GitHub
Star
core/model/smarty/plugins/function.html_options.php

Summary

Maintainability
F
3 days
Test Coverage

Function smarty_function_html_options has a Cognitive Complexity of 53 (exceeds 5 allowed). Consider refactoring.
Open

function smarty_function_html_options($params, Smarty_Internal_Template $template)
{
    $template->_checkPlugins(
        array(
            array(
Severity: Minor
Found in core/model/smarty/plugins/function.html_options.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method smarty_function_html_options has 112 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function smarty_function_html_options($params, Smarty_Internal_Template $template)
{
    $template->_checkPlugins(
        array(
            array(
Severity: Major
Found in core/model/smarty/plugins/function.html_options.php - About 4 hrs to fix

    Function smarty_function_html_options_optoutput has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    function smarty_function_html_options_optoutput($key, $value, $selected, $id, $class, &$idx)
{
    if (!is_array($value)) {
        $_key = smarty_function_escape_special_chars($key);
        $_html_result = '<option value="' . $_key . '"';
    Severity: Minor
    Found in core/model/smarty/plugins/function.html_options.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method smarty_function_html_options_optoutput has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function smarty_function_html_options_optoutput($key, $value, $selected, $id, $class, &$idx)
{
    if (!is_array($value)) {
        $_key = smarty_function_escape_special_chars($key);
        $_html_result = '<option value="' . $_key . '"';
    Severity: Minor
    Found in core/model/smarty/plugins/function.html_options.php - About 1 hr to fix

      Method smarty_function_html_options_optoutput has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      function smarty_function_html_options_optoutput($key, $value, $selected, $id, $class, &$idx)
      Severity: Minor
      Found in core/model/smarty/plugins/function.html_options.php - About 45 mins to fix

        Method smarty_function_html_options_optgroup has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function smarty_function_html_options_optgroup($key, $values, $selected, $id, $class, &$idx)
        Severity: Minor
        Found in core/model/smarty/plugins/function.html_options.php - About 45 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      case 'selected':
                if (is_array($_val)) {
                    $selected = array();
                    foreach ($_val as $_sel) {
                        if (is_object($_sel)) {
          Severity: Major
          Found in core/model/smarty/plugins/function.html_options.php and 1 other location - About 7 hrs to fix
          core/model/smarty/plugins/function.html_checkboxes.php on lines 84..117

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 243.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

                      case 'readonly':
                if (!empty($params[ 'strict' ])) {
                    if (!is_scalar($_val)) {
                        trigger_error(
                            "html_options: {$_key} attribute must be a scalar, only boolean true or string '{$_key}' will actually add the attribute",
          Severity: Major
          Found in core/model/smarty/plugins/function.html_options.php and 2 other locations - About 1 hr to fix
          core/model/smarty/plugins/function.html_checkboxes.php on lines 130..142
          core/model/smarty/plugins/function.html_radios.php on lines 113..125

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 104.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status