modxcms/revolution

View on GitHub
core/model/smarty/sysplugins/smarty_internal_cacheresource_file.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method populate has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function populate(Smarty_Template_Cached $cached, Smarty_Internal_Template $_template)
    {
        $source = &$_template->source;
        $smarty = &$_template->smarty;
        $_compile_dir_sep = $smarty->use_sub_dirs ? DIRECTORY_SEPARATOR : '^';
Severity: Minor
Found in core/model/smarty/sysplugins/smarty_internal_cacheresource_file.php - About 1 hr to fix

    Function writeCachedContent has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function writeCachedContent(Smarty_Internal_Template $_template, $content)
        {
            if ($_template->smarty->ext->_writeFile->writeFile(
                    $_template->cached->filepath,
                    $content,
    Severity: Minor
    Found in core/model/smarty/sysplugins/smarty_internal_cacheresource_file.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method clear has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function clear(Smarty $smarty, $resource_name, $cache_id, $compile_id, $exp_time)
    Severity: Minor
    Found in core/model/smarty/sysplugins/smarty_internal_cacheresource_file.php - About 35 mins to fix

      Function populate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function populate(Smarty_Template_Cached $cached, Smarty_Internal_Template $_template)
          {
              $source = &$_template->source;
              $smarty = &$_template->smarty;
              $_compile_dir_sep = $smarty->use_sub_dirs ? DIRECTORY_SEPARATOR : '^';
      Severity: Minor
      Found in core/model/smarty/sysplugins/smarty_internal_cacheresource_file.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status