modxcms/revolution

View on GitHub
core/model/smarty/sysplugins/smarty_internal_compilebase.php

Summary

Maintainability
C
1 day
Test Coverage

Function getAttributes has a Cognitive Complexity of 54 (exceeds 5 allowed). Consider refactoring.
Open

    public function getAttributes($compiler, $attributes)
    {
        $_indexed_attr = array();
        if (!isset($this->mapCache[ 'option' ])) {
            $this->mapCache[ 'option' ] = array_fill_keys($this->option_flags, true);
Severity: Minor
Found in core/model/smarty/sysplugins/smarty_internal_compilebase.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getAttributes has 71 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getAttributes($compiler, $attributes)
    {
        $_indexed_attr = array();
        if (!isset($this->mapCache[ 'option' ])) {
            $this->mapCache[ 'option' ] = array_fill_keys($this->option_flags, true);
Severity: Major
Found in core/model/smarty/sysplugins/smarty_internal_compilebase.php - About 2 hrs to fix

    Function closeTag has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function closeTag($compiler, $expectedTag)
        {
            if (count($compiler->_tag_stack) > 0) {
                // get stacked info
                list($_openTag, $_data) = array_pop($compiler->_tag_stack);
    Severity: Minor
    Found in core/model/smarty/sysplugins/smarty_internal_compilebase.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status