modxcms/revolution

View on GitHub
core/model/smarty/sysplugins/smarty_internal_method_loadplugin.php

Summary

Maintainability
C
1 day
Test Coverage

Function loadPlugin has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
Open

    public function loadPlugin(Smarty $smarty, $plugin_name, $check)
    {
        // if function or class exists, exit silently (already loaded)
        if ($check && (is_callable($plugin_name) || class_exists($plugin_name, false))) {
            return true;
Severity: Minor
Found in core/model/smarty/sysplugins/smarty_internal_method_loadplugin.php - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method loadPlugin has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function loadPlugin(Smarty $smarty, $plugin_name, $check)
    {
        // if function or class exists, exit silently (already loaded)
        if ($check && (is_callable($plugin_name) || class_exists($plugin_name, false))) {
            return true;
Severity: Major
Found in core/model/smarty/sysplugins/smarty_internal_method_loadplugin.php - About 2 hrs to fix

    Avoid too many return statements within this method.
    Open

            return false;
    Severity: Major
    Found in core/model/smarty/sysplugins/smarty_internal_method_loadplugin.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                          return $this->plugin_files[ 'plugins_dir' ][ $_lower_filename ];
      Severity: Major
      Found in core/model/smarty/sysplugins/smarty_internal_method_loadplugin.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                            return $file;
        Severity: Major
        Found in core/model/smarty/sysplugins/smarty_internal_method_loadplugin.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                                  return $file;
          Severity: Major
          Found in core/model/smarty/sysplugins/smarty_internal_method_loadplugin.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                return false;
            Severity: Major
            Found in core/model/smarty/sysplugins/smarty_internal_method_loadplugin.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                  return $this->plugin_files[ 'include_path' ][ $_lower_filename ];
              Severity: Major
              Found in core/model/smarty/sysplugins/smarty_internal_method_loadplugin.php - About 30 mins to fix

                There are no issues that match your filters.

                Category
                Status