modxcms/revolution

View on GitHub
core/model/smarty/sysplugins/smarty_internal_templatebase.php

Summary

Maintainability
C
1 day
Test Coverage

Function _execute has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
Open

    private function _execute($template, $cache_id, $compile_id, $parent, $function)
    {
        $smarty = $this->_getSmartyObj();
        $saveVars = true;
        if ($template === null) {
Severity: Minor
Found in core/model/smarty/sysplugins/smarty_internal_templatebase.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _execute has 85 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function _execute($template, $cache_id, $compile_id, $parent, $function)
    {
        $smarty = $this->_getSmartyObj();
        $saveVars = true;
        if ($template === null) {
Severity: Major
Found in core/model/smarty/sysplugins/smarty_internal_templatebase.php - About 3 hrs to fix

    Method registerPlugin has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function registerPlugin($type, $name, $callback, $cacheable = true, $cache_attr = null)
    Severity: Minor
    Found in core/model/smarty/sysplugins/smarty_internal_templatebase.php - About 35 mins to fix

      Method _execute has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          private function _execute($template, $cache_id, $compile_id, $parent, $function)
      Severity: Minor
      Found in core/model/smarty/sysplugins/smarty_internal_templatebase.php - About 35 mins to fix

        Method registerObject has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                $object_name,
                $object,
                $allowed_methods_properties = array(),
                $format = true,
                $block_methods = array()
        Severity: Minor
        Found in core/model/smarty/sysplugins/smarty_internal_templatebase.php - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status