modxcms/revolution

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        foreach ($contexts as $context) {
            /** @var modAccessResourceGroup $acl */
            $acl = $this->modx->newObject('modAccessResourceGroup');
            $acl->fromArray(array(
                'context_key' => trim($context),

• Read up
  Read up

Consider simplifying this complex logical expression.

Open

                    if( ( proxyXHR.statusText != 'abort' || proxyXHR.current ) && data ){
                        // Mark active job
                        _complete = false;

                        // Set current upload file

Consider simplifying this complex logical expression.

Open

        if( navigator.plugins && typeof navigator.plugins['Shockwave Flash'] == 'object' ){
            has    = navigator.plugins['Shockwave Flash'].description && !(mime && mime['application/x-shockwave-flash'] && !mime['application/x-shockwave-flash'].enabledPlugin);
        }
        else {
            try {

Consider simplifying this complex logical expression.

Open

        } else if ((tag == "tbody" && (where == beforeend || where == afterbegin)) || 
                   (tag == "tr" && (where == beforebegin || where == afterend))) {
            node = ieTable(3, tbs, html, tbe);
        } else {
             node = ieTable(2, ts, html, te);   

Consider simplifying this complex logical expression.

Open

                                if (((!xhr.status && !xhr.aborted) || 500 == xhr.status) && (options.retry || 0) < options.uploadRetry) {
                                    options.retry = (options.retry || 0) + 1;
                                    var delay = api.networkDownRetryTimeout;

                                    // inform about recoverable problems

Consider simplifying this complex logical expression.

Open

          if(tag == 'td' && (where == afterbegin || where == beforeend) ||
             !/td|tr|tbody/i.test(tag) && (where == beforebegin || where == afterend)) { 
            return;
        }

Consider simplifying this complex logical expression.

Open

    if ('success' in data.response && data.response.success) {
      data.record.set('state', Ext.ux.UploadDialog.FileRecord.STATE_FINISHED);
      data.record.set(
        'note', data.response.message || data.response.error || this.i18n.note_upload_success
      );

Consider simplifying this complex logical expression.

Open

        if (this.editable !== false && (!e.isSpecialKey() || e.getKey() === e.BACKSPACE) && this.itemDelimiterKey.indexOf !== e.getKey()  && (!e.hasModifier() || e.shiftKey)) {
            this.lastKey = e.getKey();
            this.dqTask.delay(this.queryDelay);
        }        

Consider simplifying this complex logical expression.

Open

        if ((r.overridden == 2 && !def) || (r.overridden != 1 && def) || (!r.overridden && !def)) {
            m.push({
                text: _('property_remove')
                ,scope: this
                ,handler: this.remove.createDelegate(this,[{

Consider simplifying this complex logical expression.

Open

        if (t == 'combo-boolean') {
            v = (v == '1' || v == 'true' || v == 1 || v == true || v == _('yes') || v == 'yes') ? 1 : 0;
            fld.setValue(v);
        }

Consider simplifying this complex logical expression.

Open

        if (t == 'combo-boolean') {
            v = (v == '1' || v == 'true' || v == 1 || v == true || v == _('yes') || v == 'yes') ? 1 : 0;
            fld.setValue(v);
        }

Consider simplifying this complex logical expression.

Open

        if (fld.isXType('combo') || fld.isXType('checkbox') || fld.isXType('radio') || fld.isXType('displayfield') || fld.isXType('statictextfield') || fld.isXType('hidden')) {
            i = i+1;
            fld = this.findFirstTextField(i);
        }

Consider simplifying this complex logical expression.

Open

        if (this.config.url) {            
            this.config.loader = new Ext.tree.TreeLoader({
                preloadChildren: false
                ,baseAttrs: {
                    uiProvider:MODx.tree.CheckboxNodeUI

Consider simplifying this complex logical expression.

Open

        if (fld.isXType('combo') || fld.isXType('checkbox') || fld.isXType('radio') || fld.isXType('displayfield') || fld.isXType('statictextfield') || fld.isXType('hidden')) {
            i = i+1;
            fld = this.findFirstTextField(i);
        }

Consider simplifying this complex logical expression.

Open

          if(isset($trace[$i]['class'])
             && isset($trace[$i]['file'])
             && ($trace[$i]['class']=='FirePHP'
                 || $trace[$i]['class']=='FB')
             && (substr($this->_standardizePath($trace[$i]['file']),-18,18)=='FirePHPCore/fb.php'

Consider simplifying this complex logical expression.

Open

        if(isset($trace[$i]['class'])
           && isset($trace[$i]['file'])
           && ($trace[$i]['class']=='FirePHP'
               || $trace[$i]['class']=='FB')
           && (substr($this->_standardizePath($trace[$i]['file']),-18,18)=='FirePHPCore/fb.php'

Consider simplifying this complex logical expression.

Open

        if ($target=='FILE' && $this->getCacheManager()) {
            $filename = isset($targetOptions['filename']) ? $targetOptions['filename'] : 'error.log';
            $filepath = isset($targetOptions['filepath']) ? $targetOptions['filepath'] : $this->getCachePath() . xPDOCacheManager::LOG_DIR;
            $this->cacheManager->writeFile($filepath . $filename, $content, 'a');
        } elseif ($target=='ARRAY' && isset($targetOptions['var']) && is_array($targetOptions['var'])) {

Consider simplifying this complex logical expression.

Open

        if (!($conn instanceof xPDOConnection) || ($mutable !== null && (($mutable == true && !$conn->isMutable()) || ($mutable == false && $conn->isMutable())))) {
            if (!empty($this->_connections)) {
                shuffle($this->_connections);
                $conn = reset($this->_connections);
                while ($conn) {

Consider simplifying this complex logical expression.

Open

        if (isset ($meta['index']) && $meta['index'] == 'pk' && !is_array($pk) && $pktype == 'integer' && isset ($meta['generated']) && $meta['generated'] == 'native') {
            $extra= ' IDENTITY PRIMARY KEY';
            $null= '';
        }

Consider simplifying this complex logical expression.

Open

        if (isset($meta['index']) && $meta['index'] == 'pk' && !is_array($pk) && $pktype == 'integer' && isset ($meta['generated']) && $meta['generated'] == 'native') {
            $extra= ' AUTO_INCREMENT';
        }