modxcms/revolution

View on GitHub

Showing 7,873 of 7,873 total issues

Method mutingErrorHandler has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public static function mutingErrorHandler($errno, $errstr, $errfile, $errline, $errcontext = array())
Severity: Minor
Found in core/model/smarty/sysplugins/smarty_internal_errorhandler.php - About 35 mins to fix

    Method listInvalidationKeys has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            $cid,
            $resource_name = null,
            $cache_id = null,
            $compile_id = null,
            $resource_uid = null
    Severity: Minor
    Found in core/model/smarty/sysplugins/smarty_cacheresource_keyvaluestore.php - About 35 mins to fix

      Method compile has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function compile($args, Smarty_Internal_TemplateCompilerBase $compiler, $parameter, $tag, $function)

        Method compileAllConfig has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                Smarty $smarty,
                $extension = '.conf',
                $force_compile = false,
                $time_limit = 0,
                $max_errors = null
        Severity: Minor
        Found in core/model/smarty/sysplugins/smarty_internal_method_compileallconfig.php - About 35 mins to fix

          Method getLatestInvalidationTimestamp has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  $cid,
                  $resource_name = null,
                  $cache_id = null,
                  $compile_id = null,
                  $resource_uid = null
          Severity: Minor
          Found in core/model/smarty/sysplugins/smarty_cacheresource_keyvaluestore.php - About 35 mins to fix

            Method clear has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function clear(Smarty $smarty, $resource_name, $cache_id, $compile_id, $exp_time)
            Severity: Minor
            Found in core/model/smarty/sysplugins/smarty_cacheresource_keyvaluestore.php - About 35 mins to fix

              Method compile has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public static function compile($_function, $_attr, $_template, $_script, $_assign = null)
              Severity: Minor
              Found in core/model/smarty/sysplugins/smarty_internal_nocache_insert.php - About 35 mins to fix

                Method clear has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public function clear(Smarty $smarty, $resource_name, $cache_id, $compile_id, $exp_time)
                Severity: Minor
                Found in core/model/smarty/sysplugins/smarty_internal_cacheresource_file.php - About 35 mins to fix

                  Method clear has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      public function clear(Smarty $smarty, $resource_name, $cache_id, $compile_id, $exp_time)

                    Method Crop has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public function Crop(&$gdimg, $left=0, $right=0, $top=0, $bottom=0) {
                    Severity: Minor
                    Found in core/model/phpthumb/phpthumb.filters.php - About 35 mins to fix

                      Method ImageBorder has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          public function ImageBorder(&$gdimg, $border_width, $radius_x, $radius_y, $hexcolor_border) {
                      Severity: Minor
                      Found in core/model/phpthumb/phpthumb.filters.php - About 35 mins to fix

                        Method ImageColorAllocateAlphaSafe has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            public static function ImageColorAllocateAlphaSafe(&$gdimg_hexcolorallocate, $R, $G, $B, $alpha=false) {
                        Severity: Minor
                        Found in core/model/phpthumb/phpthumb.functions.php - About 35 mins to fix

                          Method ImprovedImageRotate has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              public static function ImprovedImageRotate(&$gdimg_source, $rotate_angle, $config_background_hexcolor, $bg, &$phpThumbObject) {
                          Severity: Minor
                          Found in core/model/phpthumb/phpthumb.filters.php - About 35 mins to fix

                            Identical blocks of code found in 3 locations. Consider refactoring.
                            Open

                                        ,defaults: {
                                            layout: 'form'
                                            ,labelAlign: 'top'
                                            ,labelSeparator: ''
                                            ,border: false
                            Severity: Minor
                            Found in manager/assets/modext/widgets/resource/modx.panel.resource.js and 2 other locations - About 35 mins to fix
                            manager/assets/modext/widgets/resource/modx.panel.resource.js on lines 423..433
                            manager/assets/modext/widgets/resource/modx.panel.resource.js on lines 773..783

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 47.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 7 locations. Consider refactoring.
                            Open

                                ,cleanupEditor: function() {
                                    if (MODx.onSaveEditor) {
                                        var fld = Ext.getCmp('modx-chunk-snippet');
                                        MODx.onSaveEditor(fld);
                                    }
                            Severity: Major
                            Found in manager/assets/modext/widgets/element/modx.panel.chunk.js and 6 other locations - About 35 mins to fix
                            manager/assets/modext/sections/system/file/create.js on lines 139..144
                            manager/assets/modext/sections/system/file/edit.js on lines 157..162
                            manager/assets/modext/widgets/element/modx.panel.plugin.js on lines 407..412
                            manager/assets/modext/widgets/element/modx.panel.snippet.js on lines 370..375
                            manager/assets/modext/widgets/element/modx.panel.template.js on lines 409..414
                            manager/assets/modext/widgets/element/modx.panel.tv.js on lines 478..483

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 47.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Identical blocks of code found in 4 locations. Consider refactoring.
                            Open

                                    m.push({
                                        text: '<b>'+a.text+'</b>'
                                        ,handler: function() {return false;}
                                        ,header: true
                                    });
                            Severity: Major
                            Found in manager/assets/modext/widgets/resource/modx.tree.resource.js and 3 other locations - About 35 mins to fix
                            manager/assets/modext/widgets/element/modx.tree.element.js on lines 470..474
                            manager/assets/modext/widgets/element/modx.tree.element.js on lines 547..551
                            manager/assets/modext/widgets/resource/modx.tree.resource.js on lines 570..574

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 47.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Identical blocks of code found in 3 locations. Consider refactoring.
                            Open

                                    if (window.top.opener) {
                                        window.top.close();
                                        window.top.opener.focus();
                                    }
                            Severity: Minor
                            Found in manager/assets/modext/widgets/media/modx.browser.js and 2 other locations - About 35 mins to fix
                            manager/assets/modext/widgets/core/modx.rte.browser.js on lines 233..236
                            manager/assets/modext/widgets/media/modx.browser.js on lines 1516..1519

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 47.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Identical blocks of code found in 3 locations. Consider refactoring.
                            Open

                                        if (window.top.opener) {
                                            window.top.close();
                                            window.top.opener.focus();
                                        }
                            Severity: Minor
                            Found in manager/assets/modext/widgets/media/modx.browser.js and 2 other locations - About 35 mins to fix
                            manager/assets/modext/widgets/core/modx.rte.browser.js on lines 233..236
                            manager/assets/modext/widgets/media/modx.browser.js on lines 1528..1531

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 47.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 7 locations. Consider refactoring.
                            Open

                                ,cleanupEditor: function() {
                                    if (MODx.onSaveEditor) {
                                        var fld = Ext.getCmp('modx-plugin-plugincode');
                                        MODx.onSaveEditor(fld);
                                    }
                            Severity: Major
                            Found in manager/assets/modext/widgets/element/modx.panel.plugin.js and 6 other locations - About 35 mins to fix
                            manager/assets/modext/sections/system/file/create.js on lines 139..144
                            manager/assets/modext/sections/system/file/edit.js on lines 157..162
                            manager/assets/modext/widgets/element/modx.panel.chunk.js on lines 362..367
                            manager/assets/modext/widgets/element/modx.panel.snippet.js on lines 370..375
                            manager/assets/modext/widgets/element/modx.panel.template.js on lines 409..414
                            manager/assets/modext/widgets/element/modx.panel.tv.js on lines 478..483

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 47.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 7 locations. Consider refactoring.
                            Open

                                ,cleanupEditor: function() {
                                    if (MODx.onSaveEditor) {
                                        var fld = Ext.getCmp('modx-tv-default-text');
                                        MODx.onSaveEditor(fld);
                                    }
                            Severity: Major
                            Found in manager/assets/modext/widgets/element/modx.panel.tv.js and 6 other locations - About 35 mins to fix
                            manager/assets/modext/sections/system/file/create.js on lines 139..144
                            manager/assets/modext/sections/system/file/edit.js on lines 157..162
                            manager/assets/modext/widgets/element/modx.panel.chunk.js on lines 362..367
                            manager/assets/modext/widgets/element/modx.panel.plugin.js on lines 407..412
                            manager/assets/modext/widgets/element/modx.panel.snippet.js on lines 370..375
                            manager/assets/modext/widgets/element/modx.panel.template.js on lines 409..414

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 47.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Severity
                            Category
                            Status
                            Source
                            Language