Sign upLogin

modxcms/revolution

View on GitHub
Star
manager/min/lib/HTTP/Encoder.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method getAcceptedEncoding has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function getAcceptedEncoding($allowCompress = true, $allowDeflate = true)
    {
        // @link http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html
        
        if (! isset($_SERVER['HTTP_ACCEPT_ENCODING'])
Severity: Minor
Found in manager/min/lib/HTTP/Encoder.php - About 1 hr to fix

    Method encode has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function encode($compressionLevel = null)
    {
        if (! self::isBuggyIe()) {
            $this->_headers['Vary'] = 'Accept-Encoding';
        }
    Severity: Minor
    Found in manager/min/lib/HTTP/Encoder.php - About 1 hr to fix

      Function getAcceptedEncoding has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function getAcceptedEncoding($allowCompress = true, $allowDeflate = true)
    {
        // @link http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html
        
        if (! isset($_SERVER['HTTP_ACCEPT_ENCODING'])
      Severity: Minor
      Found in manager/min/lib/HTTP/Encoder.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function encode has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public function encode($compressionLevel = null)
    {
        if (! self::isBuggyIe()) {
            $this->_headers['Vary'] = 'Accept-Encoding';
        }
      Severity: Minor
      Found in manager/min/lib/HTTP/Encoder.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

              return array('', '');
      Severity: Major
      Found in manager/min/lib/HTTP/Encoder.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return array('compress', $m[1]);
        Severity: Major
        Found in manager/min/lib/HTTP/Encoder.php - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status