Sign upLogin

modxcms/revolution

View on GitHub
Star
manager/min/lib/JSMinPlus.php

Summary

Maintainability
F
2 wks
Test Coverage

File JSMinPlus.php has 1633 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * JSMinPlus version 1.4
 *
Severity: Major
Found in manager/min/lib/JSMinPlus.php - About 4 days to fix

    Function Expression has a Cognitive Complexity of 164 (exceeds 5 allowed). Consider refactoring.
    Open

        private function Expression($x, $stop=false)
    {
        $operators = array();
        $operands = array();
        $n = false;
    Severity: Minor
    Found in manager/min/lib/JSMinPlus.php - About 3 days to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function parseTree has a Cognitive Complexity of 119 (exceeds 5 allowed). Consider refactoring.
    Open

        public function parseTree($n, $noBlockGrouping = false)
    {
        $s = '';

        switch ($n->type)
    Severity: Minor
    Found in manager/min/lib/JSMinPlus.php - About 2 days to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method parseTree has 351 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function parseTree($n, $noBlockGrouping = false)
    {
        $s = '';

        switch ($n->type)
    Severity: Major
    Found in manager/min/lib/JSMinPlus.php - About 1 day to fix

      Function get has a Cognitive Complexity of 84 (exceeds 5 allowed). Consider refactoring.
      Open

          public function get($chunksize = 1000)
    {
        while($this->lookahead)
        {
            $this->lookahead--;
      Severity: Minor
      Found in manager/min/lib/JSMinPlus.php - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method Expression has 296 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function Expression($x, $stop=false)
    {
        $operators = array();
        $operands = array();
        $n = false;
      Severity: Major
      Found in manager/min/lib/JSMinPlus.php - About 1 day to fix

        Function Statement has a Cognitive Complexity of 72 (exceeds 5 allowed). Consider refactoring.
        Open

            private function Statement($x)
    {
        $tt = $this->t->get();
        $n2 = null;
        Severity: Minor
        Found in manager/min/lib/JSMinPlus.php - About 1 day to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method Statement has 261 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function Statement($x)
    {
        $tt = $this->t->get();
        $n2 = null;
        Severity: Major
        Found in manager/min/lib/JSMinPlus.php - About 1 day to fix

          Method get has 188 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function get($chunksize = 1000)
    {
        while($this->lookahead)
        {
            $this->lookahead--;
          Severity: Major
          Found in manager/min/lib/JSMinPlus.php - About 7 hrs to fix

            Method reduce has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private function reduce(&$operators, &$operands)
    {
        $n = array_pop($operators);
        $op = $n->type;
        $arity = $this->opArity[$op];
            Severity: Minor
            Found in manager/min/lib/JSMinPlus.php - About 1 hr to fix

              Method FunctionDefinition has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function FunctionDefinition($x, $requireName, $functionForm)
    {
        $f = new JSNode($this->t);

        if ($f->type != KEYWORD_FUNCTION)
              Severity: Minor
              Found in manager/min/lib/JSMinPlus.php - About 1 hr to fix

                Function FunctionDefinition has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function FunctionDefinition($x, $requireName, $functionForm)
    {
        $f = new JSNode($this->t);

        if ($f->type != KEYWORD_FUNCTION)
                Severity: Minor
                Found in manager/min/lib/JSMinPlus.php - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function reduce has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function reduce(&$operators, &$operands)
    {
        $n = array_pop($operators);
        $op = $n->type;
        $arity = $this->opArity[$op];
                Severity: Minor
                Found in manager/min/lib/JSMinPlus.php - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid deeply nested control flow statements.
                Open

                                            if ($ss[$i]->label == $label)
                                throw $this->t->newSyntaxError('Duplicate label');
                Severity: Major
                Found in manager/min/lib/JSMinPlus.php - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                                          if ($x->ecmaStrictMode)
                                            throw $this->t->newSyntaxError('Illegal trailing ,');
                  Severity: Major
                  Found in manager/min/lib/JSMinPlus.php - About 45 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                        return $n;
                    Severity: Major
                    Found in manager/min/lib/JSMinPlus.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                              return $n;
                      Severity: Major
                      Found in manager/min/lib/JSMinPlus.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return $n;
                        Severity: Major
                        Found in manager/min/lib/JSMinPlus.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                      return $n;
                          Severity: Major
                          Found in manager/min/lib/JSMinPlus.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                    return $n;
                            Severity: Major
                            Found in manager/min/lib/JSMinPlus.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                          return $n;
                              Severity: Major
                              Found in manager/min/lib/JSMinPlus.php - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                            return $n;
                                Severity: Major
                                Found in manager/min/lib/JSMinPlus.php - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                              return $n;
                                  Severity: Major
                                  Found in manager/min/lib/JSMinPlus.php - About 30 mins to fix

                                    Avoid too many return statements within this method.
                                    Open

                                                return $n;
                                    Severity: Major
                                    Found in manager/min/lib/JSMinPlus.php - About 30 mins to fix

                                      Function peek has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                      Open

                                          public function peek()
    {
        if ($this->lookahead)
        {
            $next = $this->tokens[($this->tokenIndex + $this->lookahead) & 3];
                                      Severity: Minor
                                      Found in manager/min/lib/JSMinPlus.php - About 25 mins to fix

                                      Cognitive Complexity

                                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                      A method's cognitive complexity is based on a few simple rules:

                                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                      • Code is considered more complex for each "break in the linear flow of the code"
                                      • Code is considered more complex when "flow breaking structures are nested"

                                      Further reading

                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                          private $keywords = array(
        'break',
        'case', 'catch', 'const', 'continue',
        'debugger', 'default', 'delete', 'do',
        'else', 'enum',
                                      Severity: Minor
                                      Found in manager/min/lib/JSMinPlus.php and 1 other location - About 45 mins to fix
                                      core/model/phpthumb/phpthumb.class.php on lines 4204..4204

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 95.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      There are no issues that match your filters.

                                      Category
                                      Status