modxcms/revolution

View on GitHub
manager/min/lib/Minify/CSS/Compressor.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method _process has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function _process($css)
    {
        $css = str_replace("\r\n", "\n", $css);
        
        // preserve empty comment after '>'
Severity: Minor
Found in manager/min/lib/Minify/CSS/Compressor.php - About 1 hr to fix

    Function _commentCB has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function _commentCB($m)
        {
            $hasSurroundingWs = (trim($m[0]) !== $m[1]);
            $m = $m[1]; 
            // $m is the comment content w/o the surrounding tokens, 
    Severity: Minor
    Found in manager/min/lib/Minify/CSS/Compressor.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method _commentCB has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function _commentCB($m)
        {
            $hasSurroundingWs = (trim($m[0]) !== $m[1]);
            $m = $m[1]; 
            // $m is the comment content w/o the surrounding tokens, 
    Severity: Minor
    Found in manager/min/lib/Minify/CSS/Compressor.php - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

                  return '/**/';
      Severity: Major
      Found in manager/min/lib/Minify/CSS/Compressor.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return '/*/*/';
        Severity: Major
        Found in manager/min/lib/Minify/CSS/Compressor.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return '/*\\*/';
          Severity: Major
          Found in manager/min/lib/Minify/CSS/Compressor.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return $hasSurroundingWs // remove all other comments
                        ? ' '
                        : '';
            Severity: Major
            Found in manager/min/lib/Minify/CSS/Compressor.php - About 30 mins to fix

              There are no issues that match your filters.

              Category
              Status