modxcms/revolution

View on GitHub
manager/min/lib/Minify/Controller/MinApp.php

Summary

Maintainability
D
2 days
Test Coverage

Function setupSources has a Cognitive Complexity of 84 (exceeds 5 allowed). Consider refactoring.
Open

    public function setupSources($options) {
        // filter controller options
        $cOptions = array_merge(
            array(
                'allowDirs' => '//'
Severity: Minor
Found in manager/min/lib/Minify/Controller/MinApp.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method setupSources has 146 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function setupSources($options) {
        // filter controller options
        $cOptions = array_merge(
            array(
                'allowDirs' => '//'
Severity: Major
Found in manager/min/lib/Minify/Controller/MinApp.php - About 5 hrs to fix

    Avoid too many return statements within this method.
    Open

                    return $options;
    Severity: Major
    Found in manager/min/lib/Minify/Controller/MinApp.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return $options;
      Severity: Major
      Found in manager/min/lib/Minify/Controller/MinApp.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                                return $options;
        Severity: Major
        Found in manager/min/lib/Minify/Controller/MinApp.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return $options;
          Severity: Major
          Found in manager/min/lib/Minify/Controller/MinApp.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                return $options;
            Severity: Major
            Found in manager/min/lib/Minify/Controller/MinApp.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                  return $options;
              Severity: Major
              Found in manager/min/lib/Minify/Controller/MinApp.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return $options;
                Severity: Major
                Found in manager/min/lib/Minify/Controller/MinApp.php - About 30 mins to fix

                  Function checkType has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function checkType($sourceOrExt)
                      {
                          if ($sourceOrExt === 'js') {
                              $type = Minify::TYPE_JS;
                          } elseif ($sourceOrExt === 'css') {
                  Severity: Minor
                  Found in manager/min/lib/Minify/Controller/MinApp.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  There are no issues that match your filters.

                  Category
                  Status