Sign upLogin

mogox/ruby-hl7

View on GitHub
Star
lib/segment_list_storage.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method append has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

            def append(value)
              unless (value && value.kind_of?(HL7::Message::Segment))
                raise HL7::Exception.new( "attempting to append non-segment to a segment list" )
              end
Severity: Minor
Found in lib/segment_list_storage.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method define_method_children has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def define_method_children
    self.class_eval do
      define_method(:children) do
        unless @my_children
          p = self
Severity: Minor
Found in lib/segment_list_storage.rb - About 1 hr to fix

    Method << has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

                def <<( value )
              # do nothing if value is nil
              return unless value

              # make sure it's an array
    Severity: Minor
    Found in lib/segment_list_storage.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status