Sign upLogin

moip/moip-sdk-php

View on GitHub
Star
src/Resource/Payment.php

Summary

Maintainability
D
1 day
Test Coverage

Payment has 42 functions (exceeds 20 allowed). Consider refactoring.
Open

class Payment extends MoipResource
{
    /**
     * @const string
     */
Severity: Minor
Found in src/Resource/Payment.php - About 5 hrs to fix

    File Payment.php has 313 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace Moip\Resource;

use Requests;
    Severity: Minor
    Found in src/Resource/Payment.php - About 3 hrs to fix

      Method setCreditCard has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function setCreditCard($expirationMonth, $expirationYear, $number, $cvc, Holder $holder, $store = true)
      Severity: Minor
      Found in src/Resource/Payment.php - About 45 mins to fix

        Method setDeviceFingerprint has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function setDeviceFingerprint($ip, $latitude, $longitude, $userAgent, $fingerprint)
        Severity: Minor
        Found in src/Resource/Payment.php - About 35 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function capture()
    {
        $path = sprintf('/%s/%s/%s/%s', MoipResource::VERSION, self::PATH, $this->getId(), 'capture');
        if ($this->isMultipayment($this->getId())) {
            $path = sprintf('/%s/%s/%s/%s', MoipResource::VERSION, self::MULTI_PAYMENTS_PATH, $this->getId(), 'capture');
          Severity: Major
          Found in src/Resource/Payment.php and 1 other location - About 1 hr to fix
          src/Resource/Payment.php on lines 694..704

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 119.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function cancel()
    {
        $path = sprintf('/%s/%s/%s/%s', MoipResource::VERSION, self::PATH, $this->getId(), 'void');
        if ($this->isMultipayment($this->getId())) {
            $path = sprintf('/%s/%s/%s/%s', MoipResource::VERSION, self::MULTI_PAYMENTS_PATH, $this->getId(), 'void');
          Severity: Major
          Found in src/Resource/Payment.php and 1 other location - About 1 hr to fix
          src/Resource/Payment.php on lines 675..685

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 119.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status