mondora/mondora-website-back

View on GitHub

Showing 61 of 61 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

PermissionsEnum.Tasks.isParticipant = function (userId, task) {
    var isParticipant = false;
    _.forEach(task.participants, function (participant) {
        if (participant.userId === userId) {
            isParticipant = true;
Severity: Major
Found in server/models/tasks/permissions.js and 2 other locations - About 2 hrs to fix
server/models/channels/permissions.js on lines 19..27
server/models/posts/permissions.js on lines 19..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

PermissionsEnum.Posts.isAuthor = function (userId, post) {
    var isAuthor = false;
    _.forEach(post.authors, function (author) {
        if (author.userId === userId) {
            isAuthor = true;
Severity: Major
Found in server/models/posts/permissions.js and 2 other locations - About 2 hrs to fix
server/models/channels/permissions.js on lines 19..27
server/models/tasks/permissions.js on lines 19..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

PermissionsEnum.Channels.isCurator = function (userId, channel) {
    var isCurator = false;
    _.forEach(channel.curators, function (curator) {
        if (curator.userId === userId) {
            isCurator = true;
Severity: Major
Found in server/models/channels/permissions.js and 2 other locations - About 2 hrs to fix
server/models/posts/permissions.js on lines 19..27
server/models/tasks/permissions.js on lines 19..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function method has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    method: function (form, recipients, name, description, eta, tags) {

        var templateSettings = {
            interpolate: /\{\{(.+?)\}\}/g
        };
Severity: Minor
Found in server/miscMethods/formSubmitActions.js - About 2 hrs to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    Channels.deny({
        update: function (userId, channel, fields) {
            if (PermissionsEnum.Channels.isNotCurator(userId, channel)) return;
            if (PermissionsEnum.Channels.isOwner(userId, channel)) return;
            return _.contains(fields, "userId");
    Severity: Major
    Found in server/models/channels/permissions.js and 2 other locations - About 1 hr to fix
    server/models/channels/permissions.js on lines 177..183
    server/models/tasks/permissions.js on lines 113..119

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 73.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    Tasks.deny({
        update: function (userId, task, fields) {
            if (PermissionsEnum.Tasks.isNotParticipant(userId, task)) return;
            if (PermissionsEnum.Tasks.isOwner(userId, task)) return;
            return _.contains(fields, "userId");
    Severity: Major
    Found in server/models/tasks/permissions.js and 2 other locations - About 1 hr to fix
    server/models/channels/permissions.js on lines 170..176
    server/models/channels/permissions.js on lines 177..183

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 73.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    Channels.deny({
        update: function (userId, channel, fields) {
            if (PermissionsEnum.Channels.isNotCurator(userId, channel)) return;
            if (PermissionsEnum.Channels.isOwner(userId, channel)) return;
            return _.contains(fields, "curators");
    Severity: Major
    Found in server/models/channels/permissions.js and 2 other locations - About 1 hr to fix
    server/models/channels/permissions.js on lines 170..176
    server/models/tasks/permissions.js on lines 113..119

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 73.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function downloadStravaActitivities has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    Cron.downloadStravaActitivities = function () {
        // Retrieve last activity from db
        var lastActivity = StravaActivities.findOne({}, {sort: {dateUTC: -1}});
        var params = {};
        if (lastActivity) {
    Severity: Minor
    Found in server/cron/downloadStravaActivities.js - About 1 hr to fix

      Function bookmarkPost has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          bookmarkPost: function (postId) {
              var user = Meteor.user();
              if (!user) {
                  throw new Meteor.Error("Login required");
              }
      Severity: Minor
      Found in server/models/posts/methods.js - About 1 hr to fix

        Function sendWeeklyDigest has 46 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        Cron.sendWeeklyDigest = function () {
            console.log("SENDING WEEKLY DIGEST...");
            var selector = {
                published: true,
                publishedOn: {
        Severity: Minor
        Found in server/cron/weeklyDigest.js - About 1 hr to fix

          Function addPomodoroEvent has 45 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              addPomodoroEvent: function (taskId, pomodoroId, event) {
                  var user = Meteor.user() || {};
          
                  var prevStatus;
                  var nextStatus;
          Severity: Minor
          Found in server/models/tasks/methods.js - About 1 hr to fix

            Function addCommentToPost has 44 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                addCommentToPost: function (postId, comment) {
            
                    // Get the user
                    var user = Meteor.user();
                    // Only allow logged in users to comment
            Severity: Minor
            Found in server/models/posts/methods.js - About 1 hr to fix

              Function recommendPost has 41 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  recommendPost: function (postId, userId, message) {
                      // Check arguments
                      check(postId, String);
                      check(userId, String);
                      if (message === null) {
              Severity: Minor
              Found in server/models/posts/methods.js - About 1 hr to fix

                Function recommendChannel has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    recommendChannel: function (channelId, userId, message) {
                        // Check arguments
                        check(channelId, String);
                        check(userId, String);
                        if (message === null) {
                Severity: Minor
                Found in server/models/channels/methods.js - About 1 hr to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          var notification = {
                              channel: "user:" + userId,
                              type: "taskAdded",
                              details: {
                                  taskId: task._id,
                  Severity: Major
                  Found in server/models/tasks/hooks.js and 1 other location - About 1 hr to fix
                  server/models/tasks/hooks.js on lines 26..35

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 67.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          var notification = {
                              channel: "user:" + userId,
                              type: "taskAdded",
                              details: {
                                  taskId: task._id,
                  Severity: Major
                  Found in server/models/tasks/hooks.js and 1 other location - About 1 hr to fix
                  server/models/tasks/hooks.js on lines 6..15

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 67.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Function getPermissionsSelector has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  PermissionsEnum.Channels.getPermissionsSelector = function (user) {
                      return {
                          // For the channel to be selected either:
                          $or: [
                              {
                  Severity: Minor
                  Found in server/models/channels/permissions.js - About 1 hr to fix

                    Function action has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                            action: function () {
                                var date = moment.utc({
                                    month: parseInt(this.request.query.month, 10),
                                    year: parseInt(this.request.query.year, 10)
                                });
                    Severity: Minor
                    Found in server/routes/presences.js - About 1 hr to fix

                      Function getPermissionsSelector has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      PermissionsEnum.Posts.getPermissionsSelector = function (user) {
                          return {
                              // For the post to be selected either:
                              $or: [
                                  {
                      Severity: Minor
                      Found in server/models/posts/permissions.js - About 1 hr to fix

                        Function getTopic has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            getTopic: function (name) {
                                var selector = {
                                    // Select only published posts
                                    published: true,
                                    // Which have "name" as text of a first level children
                        Severity: Minor
                        Found in server/models/posts/methods.js - About 1 hr to fix
                          Severity
                          Category
                          Status
                          Source
                          Language