moneyadviceservice/frontend

View on GitHub
app/assets/javascripts/modules/mas_collapsable.js

Summary

Maintainability
C
1 day
Test Coverage

File mas_collapsable.js has 271 lines of code (exceeds 250 allowed). Consider refactoring.
Open

define(["jquery", "common"], function ($, MAS) {
  "use strict";

  var defaults = {
    name: "not set",
Severity: Minor
Found in app/assets/javascripts/modules/mas_collapsable.js - About 2 hrs to fix

    Function _setupEach has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      Collapsible.prototype._setupEach = function (i, el) {
        var $el = $(el),
          _this = this,
          _target = _getTarget($el, _this.o),
          _items = _getItems(_target, _this.o),
    Severity: Major
    Found in app/assets/javascripts/modules/mas_collapsable.js - About 2 hrs to fix

      Function _modifyButtonHTML has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        Collapsible.prototype._modifyButtonHTML = function (i) {
          var icon, txt;
          var trigger = this.sections[i].trigger;
      
          if (this.o.showText) {
      Severity: Minor
      Found in app/assets/javascripts/modules/mas_collapsable.js - About 1 hr to fix

        Function Collapsible has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          var Collapsible = function (opts) {
            this.o = $.extend({}, defaults, opts);
            this.sections = [];
            this.selected = false;
        
        
        Severity: Minor
        Found in app/assets/javascripts/modules/mas_collapsable.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            function hideElement(element, conf) {
              element.removeClass(conf.o.activeClass).addClass(conf.o.inactiveClass);
              element.attr("aria-hidden", "true");
            }
          Severity: Major
          Found in app/assets/javascripts/modules/mas_collapsable.js and 1 other location - About 1 hr to fix
          app/assets/javascripts/modules/mas_collapsable.js on lines 309..312

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            function showElement(element, conf) {
              element.removeClass(conf.o.inactiveClass).addClass(conf.o.activeClass);
              element.attr("aria-hidden", "false");
            }
          Severity: Major
          Found in app/assets/javascripts/modules/mas_collapsable.js and 1 other location - About 1 hr to fix
          app/assets/javascripts/modules/mas_collapsable.js on lines 304..307

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status