moneyadviceservice/frontend

View on GitHub

Showing 43 of 43 total issues

File legacy_maps_redirects.rb has 1188 lines of code (exceeds 250 allowed). Consider refactoring.
Open

LEGACY_MAPS_HOST = %r{^(www.)?moneyandpensionsservice.org.uk$}.freeze

r301 %r{^/?}, 'https://adviser.moneyhelper.org.uk/en/faqs-independent-confidential-impartial-money-advice', host: 'moneyadviser.moneyhelper.org.uk'

r301 %r{^/?$}, 'https://www.maps.org.uk/en', host: LEGACY_MAPS_HOST
Severity: Major
Found in lib/legacy_maps_redirects.rb - About 3 days to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    define([], function() {
      'use strict';
    
      return {
        'hide': 'hide',
    Severity: Major
    Found in app/assets/javascripts/translations/en.js and 1 other location - About 4 hrs to fix
    app/assets/javascripts/translations/cy.js on lines 1..33

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 125.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    define([], function() {
      'use strict';
    
      return {
        'hide': 'hide', 
    Severity: Major
    Found in app/assets/javascripts/translations/cy.js and 1 other location - About 4 hrs to fix
    app/assets/javascripts/translations/en.js on lines 1..33

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 125.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Class ApplicationController has 33 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class ApplicationController < ActionController::Base
      rescue_from Mas::Cms::HttpRedirect, with: :redirect_page
      rescue_from Mas::Cms::Errors::ResourceNotFound, with: :not_found
    
      protect_from_forgery with: :exception
    Severity: Minor
    Found in app/controllers/application_controller.rb - About 4 hrs to fix

      Function CookieController has 79 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      var CookieController = function (opts) {
        this.config = Object.assign(defaults, opts);
      
        // TODO: replace locale and textStrings with the existing i18n module
        // This appears to be not functioning as it should right now
      Severity: Major
      Found in app/assets/javascripts/modules/mas_cookieController.js - About 3 hrs to fix

        File GlobalNav.js has 298 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        define(['jquery', 'DoughBaseComponent', 'mediaQueries', 'utilities', 'common'], function($, DoughBaseComponent, mediaQueries, utilities, common) {
          'use strict';
        
          var GlobalNav;
        
        
        Severity: Minor
        Found in app/assets/javascripts/components/GlobalNav.js - About 3 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              } else if (dir === 'right') {
                if ($(thisClump).next('[data-dough-nav-clump]').length > 0) {
                  $(thisClump).blur()
                    .next().children('[data-dough-nav-clump-heading]').focus();
                } else {
          Severity: Major
          Found in app/assets/javascripts/components/GlobalNav.js and 1 other location - About 2 hrs to fix
          app/assets/javascripts/components/GlobalNav.js on lines 187..203

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 93.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          CookieController.prototype.addBranding = function () {
            var textStrings = this.textStrings[this.locale];
            var brandingObj = this.config.branding;
            var brandingContent = textStrings.branding;
          
          
          Severity: Major
          Found in app/assets/javascripts/modules/mas_cookieController.js and 1 other location - About 2 hrs to fix
          app/assets/javascripts/modules/mas_cookieController.js on lines 112..120

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 93.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          CookieController.prototype.addText = function () {
            var textStrings = this.textStrings[this.locale];
            var textObj = this.config.text;
            var textContent = textStrings.text;
          
          
          Severity: Major
          Found in app/assets/javascripts/modules/mas_cookieController.js and 1 other location - About 2 hrs to fix
          app/assets/javascripts/modules/mas_cookieController.js on lines 102..110

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 93.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if (dir === 'left') {
                if ($(thisClump).prev('[data-dough-nav-clump]').length > 0) {
                  $(thisClump).blur()
                    .prev().children('[data-dough-nav-clump-heading]').focus();
                } else {
          Severity: Major
          Found in app/assets/javascripts/components/GlobalNav.js and 1 other location - About 2 hrs to fix
          app/assets/javascripts/components/GlobalNav.js on lines 194..203

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 93.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function _setUpKeyboardEvents has 68 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            GlobalNav.prototype._setUpKeyboardEvents = function() {
              var self = this;
          
              this.$globalNav.keydown(function(e) {
                if (e.which === 32 || e.which === 40) {
          Severity: Major
          Found in app/assets/javascripts/components/GlobalNav.js - About 2 hrs to fix

            File mas_collapsable.js has 271 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            define(["jquery", "common"], function ($, MAS) {
              "use strict";
            
              var defaults = {
                name: "not set",
            Severity: Minor
            Found in app/assets/javascripts/modules/mas_collapsable.js - About 2 hrs to fix

              Class StyleguideController has 22 methods (exceeds 20 allowed). Consider refactoring.
              Open

              class StyleguideController < ApplicationController
                layout 'styleguide/documentation'
              
                def layouts
                  render layout: 'styleguide/documentation'
              Severity: Minor
              Found in app/controllers/styleguide_controller.rb - About 2 hrs to fix

                Function _setupEach has 57 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  Collapsible.prototype._setupEach = function (i, el) {
                    var $el = $(el),
                      _this = this,
                      _target = _getTarget($el, _this.o),
                      _items = _getItems(_target, _this.o),
                Severity: Major
                Found in app/assets/javascripts/modules/mas_collapsable.js - About 2 hrs to fix

                  Function _modifyButtonHTML has 43 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    Collapsible.prototype._modifyButtonHTML = function (i) {
                      var icon, txt;
                      var trigger = this.sections[i].trigger;
                  
                      if (this.o.showText) {
                  Severity: Minor
                  Found in app/assets/javascripts/modules/mas_collapsable.js - About 1 hr to fix

                    Function _positionComponent has 42 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      StickyColumn.prototype._positionComponent = function() {
                        var scrollTop;
                    
                        if (!this.isInSidebar) {
                          return;
                    Severity: Minor
                    Found in app/assets/javascripts/components/StickyColumn.js - About 1 hr to fix

                      Function _setUpDesktopInteraction has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        GlobalNav.prototype._setUpDesktopInteraction = function() {
                          var self = this;
                      
                          // touch event outside of global nav triggers close subnav
                          if (!mediaQueries.atSmallViewport()) {
                      Severity: Minor
                      Found in app/assets/javascripts/components/GlobalNav.js - About 1 hr to fix

                        Function iframeResizer has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        window.iframeResizer = function(msgPrefix, targetOrigin, minFrameHeight) {
                          'use strict';
                        
                          var timer, frameDefaultOverflow;
                        
                        
                        Severity: Minor
                        Found in app/assets/javascripts/syndication/iframeResizer.js - About 1 hr to fix

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  case 39:
                                    self._moveTopLevelFocus(e.target, 'right');
                          
                                    if (level === 'subnav') {
                                      self._closeDesktopSubNav($(e.target).parents('[data-dough-subnav]'));
                          Severity: Major
                          Found in app/assets/javascripts/components/GlobalNav.js and 1 other location - About 1 hr to fix
                          app/assets/javascripts/components/GlobalNav.js on lines 110..116

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 63.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  case 37:
                                    self._moveTopLevelFocus(e.target, 'left');
                          
                                    if (level === 'subnav') {
                                      self._closeDesktopSubNav($(e.target).parents('[data-dough-subnav]'));
                          Severity: Major
                          Found in app/assets/javascripts/components/GlobalNav.js and 1 other location - About 1 hr to fix
                          app/assets/javascripts/components/GlobalNav.js on lines 124..130

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 63.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Severity
                          Category
                          Status
                          Source
                          Language