Sign upLogin

moneyadviceservice/frontend

View on GitHub
Star
app/assets/javascripts/modules/mas_cookieController.js

Summary

Maintainability
C
1 day
Test Coverage

Function CookieController has 79 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var CookieController = function (opts) {
  this.config = Object.assign(defaults, opts);

  // TODO: replace locale and textStrings with the existing i18n module
  // This appears to be not functioning as it should right now
Severity: Major
Found in app/assets/javascripts/modules/mas_cookieController.js - About 3 hrs to fix

    Function addOptionalCookies has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    CookieController.prototype.addOptionalCookies = function () {
  var textStrings = this.textStrings[this.locale];
  var analytics = {
    name: "analytics",
    recommendedState: true,
    Severity: Minor
    Found in app/assets/javascripts/modules/mas_cookieController.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      CookieController.prototype.addBranding = function () {
  var textStrings = this.textStrings[this.locale];
  var brandingObj = this.config.branding;
  var brandingContent = textStrings.branding;
      Severity: Major
      Found in app/assets/javascripts/modules/mas_cookieController.js and 1 other location - About 2 hrs to fix
      app/assets/javascripts/modules/mas_cookieController.js on lines 112..120

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 93.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      CookieController.prototype.addText = function () {
  var textStrings = this.textStrings[this.locale];
  var textObj = this.config.text;
  var textContent = textStrings.text;
      Severity: Major
      Found in app/assets/javascripts/modules/mas_cookieController.js and 1 other location - About 2 hrs to fix
      app/assets/javascripts/modules/mas_cookieController.js on lines 102..110

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 93.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          onRevoke: function () {
      window.dataLayer = window.dataLayer || [];

      window.dataLayer.push({
        event: "civicConsentResponse",
      Severity: Minor
      Found in app/assets/javascripts/modules/mas_cookieController.js and 1 other location - About 50 mins to fix
      app/assets/javascripts/modules/mas_cookieController.js on lines 142..148

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          onAccept: function () {
      window.dataLayer = window.dataLayer || [];

      window.dataLayer.push({
        event: "civicConsentResponse",
      Severity: Minor
      Found in app/assets/javascripts/modules/mas_cookieController.js and 1 other location - About 50 mins to fix
      app/assets/javascripts/modules/mas_cookieController.js on lines 150..156

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status