mongodb/mongo-ruby-driver

View on GitHub
lib/mongo/cluster/sdam_flow.rb

Summary

Maintainability
D
2 days
Test Coverage

File sdam_flow.rb has 314 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class Mongo::Cluster
  # Handles SDAM flow for a server description changed event.
  #
  # Updates server descriptions, topology descriptions and publishes
  # SDAM events.
Severity: Minor
Found in lib/mongo/cluster/sdam_flow.rb - About 3 hrs to fix

    Method server_description_changed has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

        def server_description_changed
          unless update_server_descriptions
            # All of the transitions require that server whose updated_desc we are
            # processing is still in the cluster (i.e., was not removed as a result
            # of processing another response, potentially concurrently).
    Severity: Minor
    Found in lib/mongo/cluster/sdam_flow.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method server_description_changed has 51 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def server_description_changed
          unless update_server_descriptions
            # All of the transitions require that server whose updated_desc we are
            # processing is still in the cluster (i.e., was not removed as a result
            # of processing another response, potentially concurrently).
    Severity: Major
    Found in lib/mongo/cluster/sdam_flow.rb - About 2 hrs to fix

      Method update_rs_from_primary has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def update_rs_from_primary
            if topology.replica_set_name.nil?
              @topology = Topology::ReplicaSetWithPrimary.new(
                topology.options.merge(replica_set_name: updated_desc.replica_set_name),
                topology.monitoring, self)
      Severity: Minor
      Found in lib/mongo/cluster/sdam_flow.rb - About 1 hr to fix

        Method update_rs_with_primary_from_member has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def update_rs_with_primary_from_member
              if topology.replica_set_name != updated_desc.replica_set_name
                log_warn(
                  "Removing server #{updated_desc.address.to_s} because it has an " +
                  "incorrect replica set name (#{updated_desc.replica_set_name}); " +
        Severity: Minor
        Found in lib/mongo/cluster/sdam_flow.rb - About 1 hr to fix

          Method update_rs_without_primary has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def update_rs_without_primary
                if topology.replica_set_name.nil?
                  @topology = Topology::ReplicaSetNoPrimary.new(
                    topology.options.merge(replica_set_name: updated_desc.replica_set_name),
                    topology.monitoring, self)
          Severity: Minor
          Found in lib/mongo/cluster/sdam_flow.rb - About 1 hr to fix

            Method update_rs_from_primary has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                def update_rs_from_primary
                  if topology.replica_set_name.nil?
                    @topology = Topology::ReplicaSetWithPrimary.new(
                      topology.options.merge(replica_set_name: updated_desc.replica_set_name),
                      topology.monitoring, self)
            Severity: Minor
            Found in lib/mongo/cluster/sdam_flow.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method update_rs_with_primary_from_member has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                def update_rs_with_primary_from_member
                  if topology.replica_set_name != updated_desc.replica_set_name
                    log_warn(
                      "Removing server #{updated_desc.address.to_s} because it has an " +
                      "incorrect replica set name (#{updated_desc.replica_set_name}); " +
            Severity: Minor
            Found in lib/mongo/cluster/sdam_flow.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method stale_primary? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def stale_primary?
                  if updated_desc.election_id && updated_desc.set_version
                    if topology.max_set_version && topology.max_election_id &&
                        (updated_desc.set_version < topology.max_set_version ||
                            (updated_desc.set_version == topology.max_set_version &&
            Severity: Minor
            Found in lib/mongo/cluster/sdam_flow.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method commit_changes has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def commit_changes
                  # The application-visible sequence of events should be as follows:
                  #
                  # 1. Description change for the server which we are processing;
                  # 2. Topology change, if any;
            Severity: Minor
            Found in lib/mongo/cluster/sdam_flow.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                  if topology.replica_set_name != updated_desc.replica_set_name
                    log_warn(
                      "Removing server #{updated_desc.address.to_s} because it has an " +
                      "incorrect replica set name (#{updated_desc.replica_set_name}); " +
                      "current set name is #{topology.replica_set_name}"
            Severity: Minor
            Found in lib/mongo/cluster/sdam_flow.rb and 1 other location - About 20 mins to fix
            lib/mongo/cluster/sdam_flow.rb on lines 174..183

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 28.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                  if topology.replica_set_name != updated_desc.replica_set_name
                    log_warn(
                      "Removing server #{updated_desc.address.to_s} because it has an " +
                      "incorrect replica set name (#{updated_desc.replica_set_name}); " +
                      "current set name is #{topology.replica_set_name}"
            Severity: Minor
            Found in lib/mongo/cluster/sdam_flow.rb and 1 other location - About 20 mins to fix
            lib/mongo/cluster/sdam_flow.rb on lines 233..242

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 28.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status