mongodb/mongo-ruby-driver

View on GitHub
lib/mongo/server/connection_base.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method deliver has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def deliver(message, context, options = {})
        if Lint.enabled? && !@socket
          raise Error::LintError, "Trying to deliver a message over a disconnected connection (to #{address})"
        end
        buffer = serialize(message, context)
Severity: Minor
Found in lib/mongo/server/connection_base.rb - About 1 hr to fix

    Method deliver has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

          def deliver(message, context, options = {})
            if Lint.enabled? && !@socket
              raise Error::LintError, "Trying to deliver a message over a disconnected connection (to #{address})"
            end
            buffer = serialize(message, context)
    Severity: Minor
    Found in lib/mongo/server/connection_base.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method serialize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def serialize(message, context, buffer = BSON::ByteBuffer.new)
            # Driver specifications only mandate the fixed 16MiB limit for
            # serialized BSON documents. However, the server returns its
            # active serialized BSON document size limit in the hello response,
            # which is +max_bson_object_size+ below. The +DEFAULT_MAX_BSON_OBJECT_SIZE+
    Severity: Minor
    Found in lib/mongo/server/connection_base.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status