Sign upLogin

mongoid-rspec/mongoid-rspec

View on GitHub
Star

Showing 40 of 40 total issues

Avoid too many return statements within this method.
Open

              return false
Severity: Major
Found in lib/matchers/associations.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                  return false
    Severity: Major
    Found in lib/matchers/associations.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                    return false
      Severity: Major
      Found in lib/matchers/associations.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                      return false
        Severity: Major
        Found in lib/matchers/associations.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                        return false
          Severity: Major
          Found in lib/matchers/associations.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                          return false
            Severity: Major
            Found in lib/matchers/associations.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                            return false
              Severity: Major
              Found in lib/matchers/associations.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                              return false
                Severity: Major
                Found in lib/matchers/associations.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                return false
                  Severity: Major
                  Found in lib/matchers/associations.rb - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                  return false
                    Severity: Major
                    Found in lib/matchers/associations.rb - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                    return false
                      Severity: Major
                      Found in lib/matchers/associations.rb - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                      return false
                        Severity: Major
                        Found in lib/matchers/associations.rb - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                        return false
                          Severity: Major
                          Found in lib/matchers/associations.rb - About 30 mins to fix

                            Similar blocks of code found in 3 locations. Consider refactoring.
                            Open

                                      if @association[:order]
            if @association[:order].to_s != metadata.order.to_s
              @negative_result_message = "#{@positive_result_message} ordered by #{metadata.order}"
              return false
            else
                            Severity: Minor
                            Found in lib/matchers/associations.rb and 2 other locations - About 30 mins to fix
                            lib/matchers/associations.rb on lines 158..163
                            lib/matchers/associations.rb on lines 185..190

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 32.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 3 locations. Consider refactoring.
                            Open

                                      if @association[:dependent]
            if @association[:dependent].to_s != metadata.dependent.to_s
              @negative_result_message = "#{@positive_result_message} which specified dependent as #{metadata.dependent}"
              return false
            else
                            Severity: Minor
                            Found in lib/matchers/associations.rb and 2 other locations - About 30 mins to fix
                            lib/matchers/associations.rb on lines 158..163
                            lib/matchers/associations.rb on lines 167..172

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 32.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 3 locations. Consider refactoring.
                            Open

                                      if @association[:inverse_of]
            if @association[:inverse_of].to_s != metadata.inverse_of.to_s
              @negative_result_message = "#{@positive_result_message} which is an inverse of #{metadata.inverse_of}"
              return false
            else
                            Severity: Minor
                            Found in lib/matchers/associations.rb and 2 other locations - About 30 mins to fix
                            lib/matchers/associations.rb on lines 167..172
                            lib/matchers/associations.rb on lines 185..190

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 32.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Method description has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                            Open

                                  def description
        desc = "have #{@attributes.size > 1 ? 'fields' : 'field'} named #{@attributes.collect(&:inspect).to_sentence}"
        desc << " of type #{@type.inspect}" if @type
        desc << " with alias #{@field_alias}" if @field_alias
        desc << " with default value of #{@default.inspect}" unless @default.nil?
                            Severity: Minor
                            Found in lib/matchers/have_field.rb - About 25 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Method matches? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                            Open

                                    def matches?(actual)
          return false unless @result = super(actual)

          check_maximum if @maximum
          check_minimum if @minimum
                            Severity: Minor
                            Found in lib/matchers/validations/length_of.rb - About 25 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                    def check_maximum
          if actual_max.nil?
            @negative_result_message << ' with no maximum'
            @result = false
          elsif actual_max == @maximum
                            Severity: Minor
                            Found in lib/matchers/validations/length_of.rb and 1 other location - About 20 mins to fix
                            lib/matchers/validations/length_of.rb on lines 67..76

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 28.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                    def check_minimum
          if actual_min.nil?
            @negative_result_message << ' with no minimum'
            @result = false
          elsif actual_min == @minimum
                            Severity: Minor
                            Found in lib/matchers/validations/length_of.rb and 1 other location - About 20 mins to fix
                            lib/matchers/validations/length_of.rb on lines 55..64

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 28.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Severity
                            Category
                            Status
                            Source
                            Language