Sign upLogin

mongoid-rspec/mongoid-rspec

View on GitHub
Star
lib/matchers/associations.rb

Summary

Maintainability
F
4 days
Test Coverage

Method matches? has a Cognitive Complexity of 69 (exceeds 5 allowed). Consider refactoring.
Open

        def matches?(actual)
          @actual = actual.is_a?(Class) ? actual : actual.class
          metadata = @actual.relations[@association[:name]]

          if metadata.nil?
Severity: Minor
Found in lib/matchers/associations.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method matches? has 138 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def matches?(actual)
          @actual = actual.is_a?(Class) ? actual : actual.class
          metadata = @actual.relations[@association[:name]]

          if metadata.nil?
Severity: Major
Found in lib/matchers/associations.rb - About 5 hrs to fix

    File associations.rb has 315 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    if Mongoid::Compatibility::Version.mongoid7_or_newer?
  require 'mongoid/association'
else
  require 'mongoid/relations'
end
    Severity: Minor
    Found in lib/matchers/associations.rb - About 3 hrs to fix

      Method type_description has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

              def type_description(type = nil, passive = true)
          type ||= @association[:type]
          case type.name
          when EMBEDS_ONE.name
            (passive ? 'embed' : 'embeds') << ' one'
      Severity: Minor
      Found in lib/matchers/associations.rb - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Class HaveAssociationMatcher has 22 methods (exceeds 20 allowed). Consider refactoring.
      Open

            class HaveAssociationMatcher
        def initialize(name, association_type)
          @association = {}
          @association[:name] = name.to_s
          @association[:type] = association_type
      Severity: Minor
      Found in lib/matchers/associations.rb - About 2 hrs to fix

        Avoid too many return statements within this method.
        Open

                      return false
        Severity: Major
        Found in lib/matchers/associations.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                        return false
          Severity: Major
          Found in lib/matchers/associations.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                          return false
            Severity: Major
            Found in lib/matchers/associations.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                            return false
              Severity: Major
              Found in lib/matchers/associations.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                              return false
                Severity: Major
                Found in lib/matchers/associations.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                return false
                  Severity: Major
                  Found in lib/matchers/associations.rb - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                  return false
                    Severity: Major
                    Found in lib/matchers/associations.rb - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                    return false
                      Severity: Major
                      Found in lib/matchers/associations.rb - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                      return false
                        Severity: Major
                        Found in lib/matchers/associations.rb - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                        return false
                          Severity: Major
                          Found in lib/matchers/associations.rb - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                          return false
                            Severity: Major
                            Found in lib/matchers/associations.rb - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                            return false
                              Severity: Major
                              Found in lib/matchers/associations.rb - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                              return false
                                Severity: Major
                                Found in lib/matchers/associations.rb - About 30 mins to fix

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                          HAS_MANY = Mongoid::Relations::Referenced::Many
        HAS_AND_BELONGS_TO_MANY = Mongoid::Relations::Referenced::ManyToMany
        HAS_ONE = Mongoid::Relations::Referenced::One
        BELONGS_TO = Mongoid::Relations::Referenced::In
        EMBEDS_MANY = Mongoid::Relations::Embedded::Many
                                  Severity: Minor
                                  Found in lib/matchers/associations.rb and 1 other location - About 35 mins to fix
                                  lib/matchers/associations.rb on lines 11..18

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 36.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                          HAS_MANY = Mongoid::Association::Referenced::HasMany
        HAS_AND_BELONGS_TO_MANY = Mongoid::Association::Referenced::HasAndBelongsToMany
        HAS_ONE = Mongoid::Association::Referenced::HasOne
        BELONGS_TO = Mongoid::Association::Referenced::BelongsTo
        EMBEDS_MANY = Mongoid::Association::Embedded::EmbedsMany
                                  Severity: Minor
                                  Found in lib/matchers/associations.rb and 1 other location - About 35 mins to fix
                                  lib/matchers/associations.rb on lines 19..26

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 36.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 3 locations. Consider refactoring.
                                  Open

                                            if @association[:order]
            if @association[:order].to_s != metadata.order.to_s
              @negative_result_message = "#{@positive_result_message} ordered by #{metadata.order}"
              return false
            else
                                  Severity: Minor
                                  Found in lib/matchers/associations.rb and 2 other locations - About 30 mins to fix
                                  lib/matchers/associations.rb on lines 158..163
                                  lib/matchers/associations.rb on lines 185..190

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 32.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 3 locations. Consider refactoring.
                                  Open

                                            if @association[:dependent]
            if @association[:dependent].to_s != metadata.dependent.to_s
              @negative_result_message = "#{@positive_result_message} which specified dependent as #{metadata.dependent}"
              return false
            else
                                  Severity: Minor
                                  Found in lib/matchers/associations.rb and 2 other locations - About 30 mins to fix
                                  lib/matchers/associations.rb on lines 158..163
                                  lib/matchers/associations.rb on lines 167..172

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 32.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 3 locations. Consider refactoring.
                                  Open

                                            if @association[:inverse_of]
            if @association[:inverse_of].to_s != metadata.inverse_of.to_s
              @negative_result_message = "#{@positive_result_message} which is an inverse of #{metadata.inverse_of}"
              return false
            else
                                  Severity: Minor
                                  Found in lib/matchers/associations.rb and 2 other locations - About 30 mins to fix
                                  lib/matchers/associations.rb on lines 167..172
                                  lib/matchers/associations.rb on lines 185..190

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 32.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  There are no issues that match your filters.

                                  Category
                                  Status