Sign upLogin

mordred-descriptor/mordred

View on GitHub
Star
mordred/DetourMatrix.py

Summary

Maintainability
A
3 hrs
Test Coverage

Function merge has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    def merge(self):
        for i in range(1, len(self.Q) + 1):
            ns, lsp = self.Q[-i]
            common = ns & self.nodes
            if len(common) == 0:
Severity: Minor
Found in mordred/DetourMatrix.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __call__ has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def __call__(self):
        timeout_at = None if self.timeout is None else time.time() + self.timeout

        for bcc in networkx.biconnected_component_subgraphs(self.G, False):
            lsp = LongestSimplePath(bcc, self.weight, timeout_at)()
Severity: Minor
Found in mordred/DetourMatrix.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

                return self.C[jc] + lsp[ic]
Severity: Major
Found in mordred/DetourMatrix.py - About 30 mins to fix

    Function _search has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def _search(self, u):
        if self.timeout_at < time.time():
            raise Timeout()

        self.visited.add(u)
    Severity: Minor
    Found in mordred/DetourMatrix.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status