Sign upLogin

mordred-descriptor/mordred

View on GitHub
Star
mordred/GravitationalIndex.py

Summary

Maintainability
A
1 hr
Test Coverage

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    @classmethod
    def preset(cls, version):
        return (cls(h, p) for p in [False, True] for h in [True, False])
Severity: Major
Found in mordred/GravitationalIndex.py and 2 other locations - About 50 mins to fix
mordred/ExtendedTopochemicalAtom.py on lines 453..455
mordred/ExtendedTopochemicalAtom.py on lines 511..513

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    def __str__(self):
        return "GRAV{}{}".format("" if self._heavy else "H", "p" if self._pair else "")
Severity: Major
Found in mordred/GravitationalIndex.py and 6 other locations - About 30 mins to fix
mordred/ExtendedTopochemicalAtom.py on lines 135..138
mordred/ExtendedTopochemicalAtom.py on lines 448..450
mordred/ExtendedTopochemicalAtom.py on lines 505..508
mordred/GravitationalIndex.py on lines 14..16
mordred/Weight.py on lines 15..17
mordred/Weight.py on lines 29..31

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    def description(self):
        return "{}{}gravitational index".format(
            "heavy atom " if self._heavy else "", "pair " if self._pair else ""
Severity: Major
Found in mordred/GravitationalIndex.py and 6 other locations - About 30 mins to fix
mordred/ExtendedTopochemicalAtom.py on lines 135..138
mordred/ExtendedTopochemicalAtom.py on lines 448..450
mordred/ExtendedTopochemicalAtom.py on lines 505..508
mordred/GravitationalIndex.py on lines 29..30
mordred/Weight.py on lines 15..17
mordred/Weight.py on lines 29..31

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status