morris/lessql

View on GitHub

Database has 47 functions (exceeds 20 allowed). Consider refactoring.
Open

class Database {

    /**
     * Constructor. Sets PDO to exception mode.
     *
Severity: Minor
Found in src/LessQL/Database.php - About 6 hrs to fix

    Function save has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
    Open

        function save( $recursive = true ) {
    
            $db = $this->getDatabase();
            $table = $this->getTable();
    
    
    Severity: Minor
    Found in src/LessQL/Row.php - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File Database.php has 379 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    namespace LessQL;
    
    /**
    Severity: Minor
    Found in src/LessQL/Database.php - About 5 hrs to fix

      Result has 38 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class Result implements \IteratorAggregate, \JsonSerializable {
      
          /**
           * Constructor
           * Use $db->createResult( $parent, $name ) instead
      Severity: Minor
      Found in src/LessQL/Result.php - About 5 hrs to fix

        Row has 38 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class Row implements \ArrayAccess, \IteratorAggregate, \JsonSerializable {
        
            /**
             * Constructor
             * Use $db->createRow() instead
        Severity: Minor
        Found in src/LessQL/Row.php - About 5 hrs to fix

          File Result.php has 305 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php
          
          namespace LessQL;
          
          /**
          Severity: Minor
          Found in src/LessQL/Result.php - About 3 hrs to fix

            File Row.php has 305 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php
            
            namespace LessQL;
            
            /**
            Severity: Minor
            Found in src/LessQL/Row.php - About 3 hrs to fix

              Function is has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
              Open

                  function is( $column, $value, $not = false ) {
              
                      $bang = $not ? "!" : "";
                      $or = $not ? " AND " : " OR ";
                      $novalue = $not ? "1=1" : "0=1";
              Severity: Minor
              Found in src/LessQL/Database.php - About 3 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function jsonSerialize has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
              Open

                  function jsonSerialize() {
              
                      $array = array();
              
                      foreach ( $this->_properties as $key => $value ) {
              Severity: Minor
              Found in src/LessQL/Row.php - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method save has 51 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  function save( $recursive = true ) {
              
                      $db = $this->getDatabase();
                      $table = $this->getTable();
              
              
              Severity: Major
              Found in src/LessQL/Row.php - About 2 hrs to fix

                Method execute has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    function execute() {
                
                        if ( isset( $this->rows ) ) return $this;
                
                        if ( $this->parent_ ) {
                Severity: Minor
                Found in src/LessQL/Result.php - About 1 hr to fix

                  Function execute has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                  Open

                      function execute() {
                  
                          if ( isset( $this->rows ) ) return $this;
                  
                          if ( $this->parent_ ) {
                  Severity: Minor
                  Found in src/LessQL/Result.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method is has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      function is( $column, $value, $not = false ) {
                  
                          $bang = $not ? "!" : "";
                          $or = $not ? " AND " : " OR ";
                          $novalue = $not ? "1=1" : "0=1";
                  Severity: Minor
                  Found in src/LessQL/Database.php - About 1 hr to fix

                    Function listRows has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                    Open

                        protected function listRows( &$list ) {
                    
                            $list[] = $this;
                    
                            foreach ( $this->_properties as $column => $value ) {
                    Severity: Minor
                    Found in src/LessQL/Row.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        function referenced( $name, $where = null, $params = array() ) {
                    
                            $result = $this->db->createResult( $this, $name );
                    
                            if ( $where !== null ) {
                    Severity: Major
                    Found in src/LessQL/Result.php and 1 other location - About 1 hr to fix
                    src/LessQL/Row.php on lines 141..152

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 31.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        function referenced( $name, $where = null, $params = array() ) {
                    
                            $result = $this->getDatabase()->createResult( $this, $name );
                    
                            if ( $where !== null ) {
                    Severity: Major
                    Found in src/LessQL/Row.php and 1 other location - About 1 hr to fix
                    src/LessQL/Result.php on lines 91..102

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 31.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Function __set has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                        function __set( $column, $value ) {
                    
                            if ( isset( $this->_properties[ $column ] ) && $this->_properties[ $column ] === $value ) {
                    
                                return;
                    Severity: Minor
                    Found in src/LessQL/Row.php - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function insert has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                        function insert( $table, $rows, $method = null ) {
                    
                            if ( empty( $rows ) ) return;
                            if ( !isset( $rows[ 0 ] ) ) $rows = array( $rows );
                    
                    
                    Severity: Minor
                    Found in src/LessQL/Database.php - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function updateBackReferences has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                        function updateBackReferences() {
                    
                            $id = $this->getId();
                    
                            if ( is_array( $id ) ) return $this;
                    Severity: Minor
                    Found in src/LessQL/Row.php - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Avoid too many return statements within this method.
                    Open

                                return "'" . sprintf( "%F", $value ) . "'";
                    Severity: Major
                    Found in src/LessQL/Database.php - About 30 mins to fix
                      Severity
                      Category
                      Status