Sign upLogin

moser/foxtrot_mike

View on GitHub
Star
app/helpers/filtered_flights_helper.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method group has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def group(flights, enable, &block)
    if enable
      flights = flights.dup
      while !flights.empty? do
        current = flights.first.aggregation_id
Severity: Minor
Found in app/helpers/filtered_flights_helper.rb - About 1 hr to fix

    Method group has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      def group(flights, enable, &block)
    if enable
      flights = flights.dup
      while !flights.empty? do
        current = flights.first.aggregation_id
    Severity: Minor
    Found in app/helpers/filtered_flights_helper.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method generate_filtered_flights_path has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def generate_filtered_flights_path(obj, from, to, group_by, aggregate_entries, format = :html)
    Severity: Minor
    Found in app/helpers/filtered_flights_helper.rb - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status