Sign upLogin

moser/foxtrot_mike

View on GitHub
Star
app/models/abstract_flight.rb

Summary

Maintainability
D
2 days
Test Coverage

Class AbstractFlight has 69 methods (exceeds 20 allowed). Consider refactoring.
Open

class AbstractFlight < ActiveRecord::Base
  Purposes = ['training', 'exercise', 'tow']
  IncludeAll = [:liabilities]
  before_save :replace_duplicates
  before_save :destroy_launch
Severity: Major
Found in app/models/abstract_flight.rb - About 1 day to fix

    File abstract_flight.rb has 372 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require "digest/sha2"

class AbstractFlight < ActiveRecord::Base
  Purposes = ['training', 'exercise', 'tow']
  IncludeAll = [:liabilities]
    Severity: Minor
    Found in app/models/abstract_flight.rb - About 4 hrs to fix

      Method soft_validate has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

        def soft_validate
    self.problems = {}
    problems[:too_many_people] = {} if too_many_people_for_plane?
    problems[:seat2_is_not_an_instructor] = {} if seat2_not_an_instructor?
    problems[:launch_method_impossible] = {} if launch_method_impossible?
      Severity: Minor
      Found in app/models/abstract_flight.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Consider simplifying this complex logical expression.
      Open

          if not_between_sr_and_ss?
      sr = (from && from.srss? && from.srss.sunrise_i(departure_date)) ||-1
      ss = (to && to.srss? && to.srss.sunset_i(departure_date)) ||-1
      problems[:not_between_sr_and_ss] = { :sr => DayTime.format(sr), :ss => DayTime.format(ss) }
    end
      Severity: Major
      Found in app/models/abstract_flight.rb - About 1 hr to fix

        Method launch_attributes= has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def launch_attributes=(attrs)
    unless attrs.nil?
        unless attrs == "none"
        klass = attrs.delete(:type).constantize
        if attrs[:id]
        Severity: Minor
        Found in app/models/abstract_flight.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status