Sign upLogin

moser/foxtrot_mike

View on GitHub
Star
app/models/person.rb

Summary

Maintainability
C
1 day
Test Coverage

Class Person has 38 methods (exceeds 20 allowed). Consider refactoring.
Open

class Person < ActiveRecord::Base
  MemberStates = [ :active, :passive, :passive_with_voting_right, :donor ]

  include UuidHelper
  include Membership
Severity: Minor
Found in app/models/person.rb - About 5 hrs to fix

    File person.rb has 269 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'csv'

class Person < ActiveRecord::Base
  MemberStates = [ :active, :passive, :passive_with_voting_right, :donor ]
    Severity: Minor
    Found in app/models/person.rb - About 2 hrs to fix

      Method import has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.import(hashes)
    ActiveRecord::Base.transaction do
      hashes.each do |hash|
        begin
          import_group(hash)
      Severity: Minor
      Found in app/models/person.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method lvb_member_state has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def lvb_member_state(date = Date.today)
    unless primary_member
      :secondary
    else
      if active?
      Severity: Minor
      Found in app/models/person.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method import has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def self.import(hashes)
    ActiveRecord::Base.transaction do
      hashes.each do |hash|
        begin
          import_group(hash)
      Severity: Minor
      Found in app/models/person.rb - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def merge_to(other_person)
    flights_on_seat1.each do |f|
      f.update_attribute :seat1_person, other_person
    end
    flights_on_seat2.each do |f|
        Severity: Minor
        Found in app/models/person.rb and 1 other location - About 20 mins to fix
        app/models/airfield.rb on lines 53..61

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 27.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status