Sign upLogin

mossadal/math-parser

View on GitHub
Star

Showing 188 of 188 total issues

Method factory has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function factory(Token $token)
    {
        switch ($token->getType()) {
            case TokenType::PosInt:
            case TokenType::Integer:
Severity: Minor
Found in src/MathParser/Parsing/Nodes/Node.php - About 1 hr to fix

    Method rationalFactory has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function rationalFactory(Token $token)
    {
        switch ($token->getType()) {
            case TokenType::PosInt:
            case TokenType::Integer:
    Severity: Minor
    Found in src/MathParser/Parsing/Nodes/Node.php - About 1 hr to fix

      Method canFactorsInImplicitMultiplication has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function canFactorsInImplicitMultiplication($token1, $token2)
    {
        if ($token1 === null || $token2 === null) return false;

        $check1 = (
      Severity: Minor
      Found in src/MathParser/Lexing/Token.php - About 1 hr to fix

        Function visitExpressionNode has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public function visitExpressionNode(ExpressionNode $node)
    {
        $operator = $node->getOperator();

        $leftValue = $node->getLeft()->accept($this);
        Severity: Minor
        Found in src/MathParser/Interpreting/Differentiator.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function parse has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function parse($value, $normalize=true)
    {
        if ($value === '') return null;
        if ($value === 'NAN') return new Rational(NAN, 1);
        if ($value === 'INF') return new Rational(INF, 1);
        Severity: Minor
        Found in src/MathParser/Extensions/Rational.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function numericFactors has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function numericFactors($leftOperand, $rightOperand)
    {
        if ($this->isNumeric($rightOperand) && $rightOperand->getValue() == 0) {
            throw new DivisionByZeroException();
        }
        Severity: Minor
        Found in src/MathParser/Parsing/Nodes/Factories/DivisionNodeFactory.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function rpow has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            private function rpow($a, $b)
    {
        if ($b->getDenominator() == 1) {
            $n = $b->getNumerator();
            if ($n >= 0) {
        Severity: Minor
        Found in src/MathParser/Interpreting/RationalEvaluator.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function canFactorsInImplicitMultiplication has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function canFactorsInImplicitMultiplication($token1, $token2)
    {
        if ($token1 === null || $token2 === null) return false;

        $check1 = (
        Severity: Minor
        Found in src/MathParser/Lexing/Token.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function numericTerms has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function numericTerms($leftOperand, $rightOperand)
    {
        if ($this->isNumeric($leftOperand) && $leftOperand->getValue() == 0) return $rightOperand;
        if ($this->isNumeric($rightOperand) && $rightOperand->getValue() == 0) return $leftOperand;
        Severity: Minor
        Found in src/MathParser/Parsing/Nodes/Factories/AdditionNodeFactory.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function lanczosApproximation has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            private static function lanczosApproximation($x) {
        $g = 7;
        $p = array(0.99999999999980993, 676.5203681218851, -1259.1392167224028,
            771.32342877765313, -176.61502916214059, 12.507343278686905,
            -0.13857109526572012, 9.9843695780195716e-6, 1.5056327351493116e-7);
        Severity: Minor
        Found in src/MathParser/Extensions/Math.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function visitFactorialNode has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            private function visitFactorialNode(FunctionNode $node)
    {
        $functionName = $node->getName();
        $op = $node->getOperand();
        $operand = $op->accept($this);
        Severity: Minor
        Found in src/MathParser/Interpreting/ASCIIPrinter.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function __construct has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            function __construct($left, $operator = null, $right = null)
    {
        $this->left = $this->sanitize($left);
        $this->operator = $operator;
        $this->right = $this->sanitize($right);
        Severity: Minor
        Found in src/MathParser/Parsing/Nodes/ExpressionNode.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function complexity has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function complexity()
    {
        if ($this instanceof IntegerNode || $this instanceof VariableNode || $this instanceof ConstantNode) {
            return 1;
        } elseif ($this instanceof RationalNode || $this instanceof NumberNode) {
        Severity: Minor
        Found in src/MathParser/Parsing/Nodes/Node.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

             public static function sinh($z) {
        if (!($z instanceof Complex)) $z = static::parse($z);

        return static::create(sinh($z->x)*cos($z->y), cosh($z->x)*sin($z->y));
    }
        Severity: Minor
        Found in src/MathParser/Extensions/Complex.php and 2 other locations - About 30 mins to fix
        src/MathParser/Extensions/Complex.php on lines 387..391
        src/MathParser/Extensions/Complex.php on lines 568..572

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 91.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            public static function cosh($z) {
        if (!($z instanceof Complex)) $z = static::parse($z);

        return static::create(cosh($z->x)*cos($z->y), sinh($z->x)*sin($z->y));
    }
        Severity: Minor
        Found in src/MathParser/Extensions/Complex.php and 2 other locations - About 30 mins to fix
        src/MathParser/Extensions/Complex.php on lines 387..391
        src/MathParser/Extensions/Complex.php on lines 553..557

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 91.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            public static function sin($z) {
        if (!($z instanceof Complex)) $z = static::parse($z);

        return static::create(sin($z->x)*cosh($z->y), cos($z->x)*sinh($z->y));
    }
        Severity: Minor
        Found in src/MathParser/Extensions/Complex.php and 2 other locations - About 30 mins to fix
        src/MathParser/Extensions/Complex.php on lines 553..557
        src/MathParser/Extensions/Complex.php on lines 568..572

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 91.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Avoid too many return statements within this method.
        Open

                return true;
        Severity: Major
        Found in src/MathParser/Lexing/Token.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                              return $this->nodeFactory->multiplication($power, $this->nodeFactory->multiplication($fpow, $leftValue));
          Severity: Major
          Found in src/MathParser/Interpreting/Differentiator.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return $this->nodeFactory->division($inner, $denominator);
            Severity: Major
            Found in src/MathParser/Interpreting/Differentiator.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                              return Complex::div($a, $b);
              Severity: Major
              Found in src/MathParser/Interpreting/ComplexEvaluator.php - About 30 mins to fix
                Severity
                Category
                Status
                Source
                Language