Sign upLogin

mossadal/math-parser

View on GitHub
Star
src/MathParser/Interpreting/RationalEvaluator.php

Summary

Maintainability
D
1 day
Test Coverage

File RationalEvaluator.php has 273 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*
 * @author      Frank Wikström <frank@mossadal.se>
 * @copyright   2016 Frank Wikström
 * @license     http://www.opensource.org/licenses/lgpl-license.php LGPL
Severity: Minor
Found in src/MathParser/Interpreting/RationalEvaluator.php - About 2 hrs to fix

    Function ifactor has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function ifactor($n)
    {

        // max_n = 2^31-1 = 2147483647
        $d = 2;
    Severity: Minor
    Found in src/MathParser/Interpreting/RationalEvaluator.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method visitFunctionNode has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function visitFunctionNode(FunctionNode $node)
    {
        $inner = $node->getOperand()->accept($this);

        switch ($node->getName()) {
    Severity: Minor
    Found in src/MathParser/Interpreting/RationalEvaluator.php - About 1 hr to fix

      Method ifactor has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function ifactor($n)
    {

        // max_n = 2^31-1 = 2147483647
        $d = 2;
      Severity: Minor
      Found in src/MathParser/Interpreting/RationalEvaluator.php - About 1 hr to fix

        Method visitExpressionNode has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function visitExpressionNode(ExpressionNode $node)
    {
        $operator = $node->getOperator();

        $a = $node->getLeft()->accept($this);
        Severity: Minor
        Found in src/MathParser/Interpreting/RationalEvaluator.php - About 1 hr to fix

          Method rpow has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function rpow($a, $b)
    {
        if ($b->getDenominator() == 1) {
            $n = $b->getNumerator();
            if ($n >= 0) {
          Severity: Minor
          Found in src/MathParser/Interpreting/RationalEvaluator.php - About 1 hr to fix

            Function rpow has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                private function rpow($a, $b)
    {
        if ($b->getDenominator() == 1) {
            $n = $b->getNumerator();
            if ($n >= 0) {
            Severity: Minor
            Found in src/MathParser/Interpreting/RationalEvaluator.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                                return new RationalNode(Math::SemiFactorial($inner->getNumerator()), 1);
            Severity: Major
            Found in src/MathParser/Interpreting/RationalEvaluator.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                              return $this->rpow($a, $b);
              Severity: Major
              Found in src/MathParser/Interpreting/RationalEvaluator.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                    return new RationalNode(Math::Factorial($inner->getNumerator()), 1);
                Severity: Major
                Found in src/MathParser/Interpreting/RationalEvaluator.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return new RationalNode($p, $q);
                  Severity: Major
                  Found in src/MathParser/Interpreting/RationalEvaluator.php - About 30 mins to fix

                    Function visitFunctionNode has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function visitFunctionNode(FunctionNode $node)
    {
        $inner = $node->getOperand()->accept($this);

        switch ($node->getName()) {
                    Severity: Minor
                    Found in src/MathParser/Interpreting/RationalEvaluator.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    There are no issues that match your filters.

                    Category
                    Status