Sign upLogin

mossadal/math-parser

View on GitHub
Star
src/MathParser/Parsing/Nodes/ExpressionNode.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method __construct has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function __construct($left, $operator = null, $right = null)
    {
        $this->left = $this->sanitize($left);
        $this->operator = $operator;
        $this->right = $this->sanitize($right);
Severity: Minor
Found in src/MathParser/Parsing/Nodes/ExpressionNode.php - About 1 hr to fix

    Function __construct has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        function __construct($left, $operator = null, $right = null)
    {
        $this->left = $this->sanitize($left);
        $this->operator = $operator;
        $this->right = $this->sanitize($right);
    Severity: Minor
    Found in src/MathParser/Parsing/Nodes/ExpressionNode.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return $thisLeft->compareTo($otherLeft) && $thisRight->compareTo($otherRight);
    Severity: Major
    Found in src/MathParser/Parsing/Nodes/ExpressionNode.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return false;
      Severity: Major
      Found in src/MathParser/Parsing/Nodes/ExpressionNode.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return $otherRight=== null && $thisLeft->compareTo($otherLeft);
        Severity: Major
        Found in src/MathParser/Parsing/Nodes/ExpressionNode.php - About 30 mins to fix

          Function compareTo has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function compareTo($other)
    {
        if ($other === null) {
            return false;
        }
          Severity: Minor
          Found in src/MathParser/Parsing/Nodes/ExpressionNode.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status