Sign upLogin

mossadal/math-parser

View on GitHub
Star
src/MathParser/Parsing/Nodes/Factories/DivisionNodeFactory.php

Summary

Maintainability
A
1 hr
Test Coverage

Function numericFactors has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    protected function numericFactors($leftOperand, $rightOperand)
    {
        if ($this->isNumeric($rightOperand) && $rightOperand->getValue() == 0) {
            throw new DivisionByZeroException();
        }
Severity: Minor
Found in src/MathParser/Parsing/Nodes/Factories/DivisionNodeFactory.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

            return new RationalNode($p, $q);
Severity: Major
Found in src/MathParser/Parsing/Nodes/Factories/DivisionNodeFactory.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

            return null;
    Severity: Major
    Found in src/MathParser/Parsing/Nodes/Factories/DivisionNodeFactory.php - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status