mossadal/math-parser

View on GitHub
src/MathParser/Parsing/Nodes/Factories/MultiplicationNodeFactory.php

Summary

Maintainability
B
4 hrs
Test Coverage

Function numericFactors has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    private function numericFactors($leftOperand, $rightOperand)
    {
        if ($this->isNumeric($rightOperand)) {
            if ($rightOperand->getValue() == 0) return new IntegerNode(0);
            if ($rightOperand->getValue() == 1) return $leftOperand;

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

            return null;
Severity: Major
Found in src/MathParser/Parsing/Nodes/Factories/MultiplicationNodeFactory.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                return new IntegerNode($leftOperand->getValue() * $rightOperand->getValue());
    Severity: Major
    Found in src/MathParser/Parsing/Nodes/Factories/MultiplicationNodeFactory.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return new RationalNode($p, $q);
      Severity: Major
      Found in src/MathParser/Parsing/Nodes/Factories/MultiplicationNodeFactory.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return null;
        Severity: Major
        Found in src/MathParser/Parsing/Nodes/Factories/MultiplicationNodeFactory.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return new NumberNode($leftOperand->getValue() * $rightOperand->getValue());
          Severity: Major
          Found in src/MathParser/Parsing/Nodes/Factories/MultiplicationNodeFactory.php - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status