src/MathParser/Parsing/Nodes/Node.php
Method factory
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public static function factory(Token $token)
{
switch ($token->getType()) {
case TokenType::PosInt:
case TokenType::Integer:
Method rationalFactory
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public static function rationalFactory(Token $token)
{
switch ($token->getType()) {
case TokenType::PosInt:
case TokenType::Integer:
Function complexity
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
public function complexity()
{
if ($this instanceof IntegerNode || $this instanceof VariableNode || $this instanceof ConstantNode) {
return 1;
} elseif ($this instanceof RationalNode || $this instanceof NumberNode) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this method. Open
Open
return new PostfixOperatorNode($token->getValue());
Avoid too many return
statements within this method. Open
Open
return null;
Avoid too many return
statements within this method. Open
Open
return new FunctionNode($token->getValue(), null);
Avoid too many return
statements within this method. Open
Open
return new ExpressionNode(null, $token->getValue(), null);
Avoid too many return
statements within this method. Open
Open
return new ExpressionNode(null, $token->getValue(), null);
Avoid too many return
statements within this method. Open
Open
return 3 + $left->complexity() + (($right === null) ? 0 : $right->complexity());
Avoid too many return
statements within this method. Open
Open
return new PostfixOperatorNode($token->getValue(), null);
Avoid too many return
statements within this method. Open
Open
return new FunctionNode($token->getValue(), null);
Avoid too many return
statements within this method. Open
Open
return true;
Avoid too many return
statements within this method. Open
Open
return 1000;
Avoid too many return
statements within this method. Open
Open
return false;
Avoid too many return
statements within this method. Open
Open
return null;
Avoid too many return
statements within this method. Open
Open
return 8 + $left->complexity() + (($right === null) ? 0 : $right->complexity());
Avoid too many return
statements within this method. Open
Open
return new SubExpressionNode($token->getValue());
Avoid too many return
statements within this method. Open
Open
return new SubExpressionNode($token->getValue());