Sign upLogin

mossadal/math-parser

View on GitHub
Star
src/MathParser/Parsing/Parser.php

Summary

Maintainability
C
1 day
Test Coverage

Function shuntingYard has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

    private function shuntingYard(array $tokens)
    {
        // Clear the oepratorStack
        $this->operatorStack = new Stack();
Severity: Minor
Found in src/MathParser/Parsing/Parser.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method shuntingYard has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function shuntingYard(array $tokens)
    {
        // Clear the oepratorStack
        $this->operatorStack = new Stack();
Severity: Major
Found in src/MathParser/Parsing/Parser.php - About 2 hrs to fix

    Function handleExpression has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function handleExpression($node)
    {
        if ($node instanceof FunctionNode) throw new ParenthesisMismatchException($node->getOperator());
        if ($node instanceof SubExpressionNode) throw new ParenthesisMismatchException($node->getOperator());
    Severity: Minor
    Found in src/MathParser/Parsing/Parser.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method handleExpression has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function handleExpression($node)
    {
        if ($node instanceof FunctionNode) throw new ParenthesisMismatchException($node->getOperator());
        if ($node instanceof SubExpressionNode) throw new ParenthesisMismatchException($node->getOperator());
    Severity: Minor
    Found in src/MathParser/Parsing/Parser.php - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

                  return $this->nodeFactory->simplify($node);
      Severity: Major
      Found in src/MathParser/Parsing/Parser.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return false;
        Severity: Major
        Found in src/MathParser/Parsing/Parser.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return $this->nodeFactory->simplify($node);
          Severity: Major
          Found in src/MathParser/Parsing/Parser.php - About 30 mins to fix

            Function handleSubExpression has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function handleSubExpression()
    {
        // Flag, checking for mismatching parentheses
        $clean = false;
            Severity: Minor
            Found in src/MathParser/Parsing/Parser.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status