motom001/DoorPi

View on GitHub
doorpi/keyboard/from_rdm6300.py

Summary

Maintainability
B
6 hrs
Test Coverage

Function readUART has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

    def readUART(self):
        while not self._shutdown:
            logger.debug("readUART() started")
            # initialize UART
            # make sure that terminal via UART is disabled
Severity: Minor
Found in doorpi/keyboard/from_rdm6300.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(self, input_pins, keyboard_name, conf_pre, conf_post, *args, **kwargs):
Severity: Minor
Found in doorpi/keyboard/from_rdm6300.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                                if now - self.last_key_time > self.__dismisstime:
                                    doorpi.DoorPi().event_handler('OnFoundTag', __name__)
                                    self.last_key = int(chars[5:-3], 16)
                                    self.last_key_time = now
                                    logger.debug("key is %s", self.last_key)
    Severity: Major
    Found in doorpi/keyboard/from_rdm6300.py - About 45 mins to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          def status_input(self, tag):
              logger.debug("status_input for tag %s", tag)
              if tag == self.last_key:
                  return True
              else:
      Severity: Major
      Found in doorpi/keyboard/from_rdm6300.py and 2 other locations - About 50 mins to fix
      doorpi/keyboard/from_pn532.py on lines 167..172
      doorpi/keyboard/from_usb_plain.py on lines 110..115

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 36.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status