Sign upLogin

mr-smithers-excellent/docker-build-push

View on GitHub
Star

Showing 7 of 7 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  if (buildOpts.buildArgs) {
    const argsSuffix = buildOpts.buildArgs.map(arg => `--build-arg ${arg}`).join(' ');
    buildCommandPrefix = `${buildCommandPrefix} ${argsSuffix}`;
  }
Severity: Major
Found in src/docker.js and 2 other locations - About 1 hr to fix
src/docker.js on lines 69..72
src/docker.js on lines 86..89

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 71.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  if (buildOpts.labels) {
    const labelsSuffix = buildOpts.labels.map(label => `--label ${label}`).join(' ');
    buildCommandPrefix = `${buildCommandPrefix} ${labelsSuffix}`;
  }
Severity: Major
Found in src/docker.js and 2 other locations - About 1 hr to fix
src/docker.js on lines 64..67
src/docker.js on lines 86..89

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 71.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  if (buildOpts.ssh) {
    const sshSuffix = buildOpts.ssh.map(ssh => `--ssh ${ssh}`).join(' ');
    buildCommandPrefix = `${buildCommandPrefix} ${sshSuffix}`;
  }
Severity: Major
Found in src/docker.js and 2 other locations - About 1 hr to fix
src/docker.js on lines 64..67
src/docker.js on lines 69..72

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 71.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function createBuildCommand has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const createBuildCommand = (imageName, dockerfile, buildOpts) => {
  const tagsSuffix = buildOpts.tags.map(tag => `-t ${imageName}:${tag}`).join(' ');
  const builder = buildOpts.multiPlatform ? 'buildx build' : 'build';

  let buildCommandPrefix = `docker ${builder} -f ${dockerfile} ${tagsSuffix}`;
Severity: Minor
Found in src/docker.js - About 1 hr to fix

    Function createTags has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const createTags = (addLatest, addTimestamp) => {
  core.info('Creating Docker image tags...');
  const { sha } = context;
  const ref = context.ref.toLowerCase();
  const shortSha = sha.substring(0, 7);
    Severity: Minor
    Found in src/docker.js - About 1 hr to fix

      Function createBuildCommand has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

      const createBuildCommand = (imageName, dockerfile, buildOpts) => {
  const tagsSuffix = buildOpts.tags.map(tag => `-t ${imageName}:${tag}`).join(' ');
  const builder = buildOpts.multiPlatform ? 'buildx build' : 'build';

  let buildCommandPrefix = `docker ${builder} -f ${dockerfile} ${tagsSuffix}`;
      Severity: Minor
      Found in src/docker.js - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function createTags has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

      const createTags = (addLatest, addTimestamp) => {
  core.info('Creating Docker image tags...');
  const { sha } = context;
  const ref = context.ref.toLowerCase();
  const shortSha = sha.substring(0, 7);
      Severity: Minor
      Found in src/docker.js - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language