Sign upLogin

mr-smithers-excellent/docker-build-push

View on GitHub
Star

Showing 4 of 7 total issues

Function createBuildCommand has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const createBuildCommand = (imageName, dockerfile, buildOpts) => {
  const tagsSuffix = buildOpts.tags.map(tag => `-t ${imageName}:${tag}`).join(' ');
  const builder = buildOpts.multiPlatform ? 'buildx build' : 'build';

  let buildCommandPrefix = `docker ${builder} -f ${dockerfile} ${tagsSuffix}`;
Severity: Minor
Found in src/docker.js - About 1 hr to fix

    Function createTags has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const createTags = (addLatest, addTimestamp) => {
  core.info('Creating Docker image tags...');
  const { sha } = context;
  const ref = context.ref.toLowerCase();
  const shortSha = sha.substring(0, 7);
    Severity: Minor
    Found in src/docker.js - About 1 hr to fix

      Function createBuildCommand has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

      const createBuildCommand = (imageName, dockerfile, buildOpts) => {
  const tagsSuffix = buildOpts.tags.map(tag => `-t ${imageName}:${tag}`).join(' ');
  const builder = buildOpts.multiPlatform ? 'buildx build' : 'build';

  let buildCommandPrefix = `docker ${builder} -f ${dockerfile} ${tagsSuffix}`;
      Severity: Minor
      Found in src/docker.js - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function createTags has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

      const createTags = (addLatest, addTimestamp) => {
  core.info('Creating Docker image tags...');
  const { sha } = context;
  const ref = context.ref.toLowerCase();
  const shortSha = sha.substring(0, 7);
      Severity: Minor
      Found in src/docker.js - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language