Sign upLogin

mrDoctorWho/vk4xmpp

View on GitHub
Star
extensions/avatar_hash.py

Summary

Maintainability
A
2 hrs
Test Coverage

Function makeHashes has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def makeHashes(self, user, uids=None):
        uids = uids or user.friends.keys()
        local = self.getLocalHashes(uids)
        if len(local) > 1:
            for uid in uids:
Severity: Minor
Found in extensions/avatar_hash.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function addPresenceHash has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

def addPresenceHash(prs, destination, source):
    if destination in Users and not prs.getType():
        user = Users[destination]
        if user.settings.avatar_hash:
            x = prs.setTag("x", namespace=xmpp.NS_VCARD_UPDATE)
Severity: Minor
Found in extensions/avatar_hash.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function handleQueue has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def handleQueue():
    while ALIVE:
        if Queue:
            user = Queue.pop()
            user.hashes = Avatars.makeHashes(user)
Severity: Minor
Found in extensions/avatar_hash.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status