Sign upLogin

mrDoctorWho/vk4xmpp

View on GitHub
Star

Showing 283 of 283 total issues

Function statustovk_prs01 has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
Open

def statustovk_prs01(source, prs, retry=3):
    if source in Users and prs.getType() in ("available", None):
        if prs.getTo() == TransportID:
            user = Users[source]
            if user.settings.status_to_vk:
Severity: Minor
Found in extensions/status.py - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __init__ has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
Open

    def __init__(self, tag=None, attrs={}, payload=[], parent=None, nsp=None, node_built=False, node=None):
        """
        Takes "tag" argument as the name of node (prepended by namespace, if needed and separated from it
        by a space), attrs dictionary as the set of arguments, payload list as the set of textual strings
        and child nodes that this node carries within itself and "parent" argument that is another node
Severity: Minor
Found in library/xmpp/simplexml.py - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function processPollResult has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
Open

def processPollResult(user, data):
    """
    Processes a poll result
    Decides whether to send a chat/groupchat message or presence or just pass the iteration
    Args:
Severity: Minor
Found in library/longpoll.py - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def __init__(self, node=None):
        """
        Create new empty data item. However, note that, according XEP-0004, DataItem MUST contain ALL
        DataFields described in DataReported.
        Alternatively other XML object can be passed in as the "node" parameted to replicate it as a new
Severity: Major
Found in library/xmpp/protocol.py and 1 other location - About 5 hrs to fix
library/xmpp/protocol.py on lines 1147..1164

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def __init__(self, node=None):
        """
        Create new empty "reported data" field. However, note that, according XEP-0004:
        * It MUST contain one or more DataFields.
        * Contained DataFields SHOULD possess a "type" and "label" attribute in addition to "var" attribute
Severity: Major
Found in library/xmpp/protocol.py and 1 other location - About 5 hrs to fix
library/xmpp/protocol.py on lines 1221..1236

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function message_handler has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

def message_handler(cl, msg):
    body = msg.getBody()
    jidTo = msg.getTo()
    destination = jidTo.getStripped()
    jidFrom = msg.getFrom()
Severity: Minor
Found in modules/mod_msg_main.py - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __str__ has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

    def __str__(self, fancy=0):
        """
        Method used to dump node into textual representation.
        if "fancy" argument is set to True produces indented output for readability.
        """
Severity: Minor
Found in library/xmpp/simplexml.py - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File auth.py has 372 lines of code (exceeds 250 allowed). Consider refactoring.
Open

##   auth.py
##
##   Copyright (C) 2003-2005 Alexey "Snake" Nezhdanov
##
##   This program is free software; you can redistribute it and/or modify
Severity: Minor
Found in library/xmpp/auth.py - About 4 hrs to fix

    Function sendMessages has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
    Open

        def sendMessages(self, init=False, messages=None, mid=0, uid=0, filter_="unread"):
        """
        Sends messages from vk to xmpp and call message01 handlers
        Args:
            init: needed to know if function called at init (add time or not)
    Severity: Minor
    Found in gateway.py - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        def FeaturesHandler(self, conn, feats):
        """
        Determine if server supports resource binding and set some internal attributes accordingly.
        """
        if not feats.getTag("bind", namespace=NS_BIND):
    Severity: Major
    Found in library/xmpp/auth.py and 1 other location - About 4 hrs to fix
    library/xmpp/auth.py on lines 292..304

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 85.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        def FeaturesHandler(self, conn, feats):
        """
        Determine if server supports resource binding and set some internal attributes accordingly.
        """
        if not feats.getTag("bind", namespace=NS_BIND):
    Severity: Major
    Found in library/xmpp/auth.py and 1 other location - About 4 hrs to fix
    library/xmpp/auth.py on lines 371..383

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 85.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Node has 36 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Node(object):
    """
    Node class describes syntax of separate XML Node. It have a constructor that permits node creation
    from set of "namespace name", attributes and payload of text strings and other nodes.
    It does not natively support building node from text string and uses NodeBuilder class for that purpose.
    Severity: Minor
    Found in library/xmpp/simplexml.py - About 4 hrs to fix

      File commands.py has 356 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      ## Ad-Hoc Command manager

## Mike Albon (c) 5th January 2005

##   This program is free software; you can redistribute it and/or modify
      Severity: Minor
      Found in library/xmpp/commands.py - About 4 hrs to fix

        Function handleChatErrors has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
        Open

        def handleChatErrors(source, prs):
    """
    Handles error presences from groupchats
    Args:
        source: the source jid
        Severity: Minor
        Found in modules/mod_groupchat_prs.py - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        File mod_iq_disco.py has 337 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        # coding: utf-8
# This file is a part of VK4XMPP transport
# © simpleApps, 2014 — 2015.
# Warning: This module contains not optimal and really ugly code.
        Severity: Minor
        Found in modules/mod_iq_disco.py - About 4 hrs to fix

          Function method has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
          Open

              def method(self, method, args=None, force=False, notoken=False):
        """
        This is a duplicate function of self.engine.method
        Needed to handle errors properly exactly in __main__
        Args:
          Severity: Minor
          Found in gateway.py - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          File client.py has 334 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          ##   client.py
##
##   Copyright (C) 2003-2005 Alexey "Snake" Nezhdanov
##
##   This program is free software; you can redistribute it and/or modify
          Severity: Minor
          Found in library/xmpp/client.py - About 4 hrs to fix

            Function colorizeJSON has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
            Open

            def colorizeJSON(data):
    if os.name != "nt":
        text = ""
        iter = list(repr(data)).__iter__()
        for c in iter:
            Severity: Minor
            Found in library/printer.py - About 3 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function interpreter_msg02 has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
            Open

            def interpreter_msg02(msg):
    body = msg.getBody()
    destination = msg.getTo().getStripped()
    source = msg.getFrom().getStripped()
    if body:
            Severity: Minor
            Found in extensions/interpreter.py - About 3 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function process has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
            Open

                def process(cls):
        """
        Processes poll sockets by select.select()
        As soon as socket will be ready for reading,  user.processPollResult() is called
        Read processPollResult.__doc__ to learn more about status codes
            Severity: Minor
            Found in library/longpoll.py - About 3 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language