Sign upLogin

mrDoctorWho/vk4xmpp

View on GitHub
Star
library/longpoll.py

Summary

Maintainability
D
2 days
Test Coverage

Function processPollResult has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
Open

def processPollResult(user, data):
    """
    Processes a poll result
    Decides whether to send a chat/groupchat message or presence or just pass the iteration
    Args:
Severity: Minor
Found in library/longpoll.py - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function process has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

    def process(cls):
        """
        Processes poll sockets by select.select()
        As soon as socket will be ready for reading,  user.processPollResult() is called
        Read processPollResult.__doc__ to learn more about status codes
Severity: Minor
Found in library/longpoll.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File longpoll.py has 303 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# coding: utf-8
# © simpleApps, 2014 — 2016.

__authors__ = ("Al Korgun <alkorgun@gmail.com>", "John Smith <mrdoctorwho@gmail.com>")
__version__ = "2.3"
Severity: Minor
Found in library/longpoll.py - About 3 hrs to fix

    Function watchdog has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def watchdog(cls):
        while cls.watchdog:
            for sock, (user, opener) in cls.__list.items():
                if (time.time() - opener.created) > OPENER_LIFETIME:
                    with cls.__lock:
    Severity: Minor
    Found in library/longpoll.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function add has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def add(cls, some_user):
        """
        Adds the User class object to poll
        """
        debug("longpoll: adding user to poll (jid: %s)", some_user.source)
    Severity: Minor
    Found in library/longpoll.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function handleUser has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def handleUser(cls, user):
        """
        Tries to reinitialize poll for LONGPOLL_RETRY_COUNT every LONGPOLL_RETRY_TIMEOUT seconds
        As soon as poll is initialized the user will be removed from buffer
        Args:
    Severity: Minor
    Found in library/longpoll.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                        if not attachments and not chat:
                        message = [{"out": 0, "from_id": uid, "id": mid, "date": date, "text": body}]
                    # we substract 1 from msg id b/c VK now has reverse history so we need to ask what happened before this exact message
                    utils.runThread(user.sendMessages, (False, message, mid - 1, uid), "sendMessages-%s" % user.source)
    Severity: Major
    Found in library/longpoll.py - About 45 mins to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          try:
        # enable keepalive probes
        sock.setsockopt(socket.SOL_SOCKET, socket.SO_KEEPALIVE, 1)
        # the interval between subsequential keepalive probes, regardless of what the connection has exchanged in the meantime
        # overrides  tcp_keepalive_intvl
      Severity: Major
      Found in library/longpoll.py and 1 other location - About 1 hr to fix
      library/xmpp/transports.py on lines 108..117

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status